ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	e0aee1baa5	Fix #3714 : declare a local function in its innermost capture scope A local function nested in a lambda can capture closures at two depths: csc emits it as an instance method on the enclosing method's display class that takes the lambda's display class as a parameter. Combining those two capture scopes with FindCommonAncestorInstruction picked the enclosing method, moving the function out of the lambda that owns the deeper closure; the variables captured there were then unreachable and the display-class parameter survived into the output as an undeclared identifier. Nested capture scopes resolve to the innermost instead, which a local function can always see - it reaches the outer closure through the display class it is declared on. Assisted-by: Claude:claude-fable-5:Claude Code	2 weeks ago
Siegfried Pammer	997d2f2db3	Recognize a closure struct of a generic method or type FindRefStructParameters dropped generic instantiations, so a parameter typed 'ref <>c__DisplayClass0_0<T>' never reached RefStructTypes. Both consumers therefore missed local functions whose declaring type or method is generic: the signature test for an obfuscated local function, and LocalFunctionNeedsAccessibilityChange, which left such a function internal while its closure struct stayed private - the recompiled output then fails with CS0051. Cross-module signatures still drop out, because the generic type part of an instantiation goes through GetTypeFromReference, which returns nil. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	3 weeks ago
Siegfried Pammer	e85d2ba00e	Detect local functions renamed by obfuscators Obfuscators strip the CompilerGeneratedAttribute and rewrite the "<caller>g__name\|x_y" name, which is all IsLocalFunctionMethod had to go on. The method then stays an ordinary static method, its display struct escapes by ref into a plain call, and TransformDisplayClassUsage correctly refuses to scalar-replace it -- so the closure fields leak into the output as "<>c__DisplayClass29_0_.iid" (issue #3202). The one marker an obfuscator cannot remove is the signature: Roslyn emits struct closures exclusively for local functions, and no hand-written C# can name a "<>c__DisplayClass" type, so a by-ref parameter of one identifies the method regardless of what it is called. #3202 Assisted-by: Claude:claude-opus-5[1m]:Claude Code	3 weeks ago
Siegfried Pammer	04505bbdf2	Highlight and scroll to the changed instruction in the ILAst view The C# debug-steps view highlights and centers the exact AST node a transform changed; the ILAst view already had the step tree and replay-at-step but produced no highlight. Bring it to parity. IL rendering has no token-writer seam like the C# output visitor, so per-instruction text spans are recorded by bracketing ILInstruction.WriteTo via a new INodeTrackingOutput. The dominant inst.ReplaceWith(newInst) transform pattern detaches the instruction passed to Step, so ILTransformContext gains EndStep to record the produced instruction; Stepper additionally records the position's ancestor chain as fallback candidates before the step-limit throw, so the "show state before" view -- which halts at the selected step -- still resolves to a surviving ancestor (ultimately the ILFunction). The highlight-range resolver is shared with the C# language. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
ds5678	1d964bce8e	Fix regression in decompiling local functions with default parameters	1 year ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	1 year ago
Siegfried Pammer	2461f520ab	Move LocalFunctionDecompiler.GetStatement to Block.GetContainingStatement	1 year ago
Siegfried Pammer	73e9771d3c	Fix #2269 : LocalFunctionDecompiler misplaces nested local functions in ctors	2 years ago
Siegfried Pammer	49942382d1	Fix #3432 : Do not include delegate construction use-sites in DetermineCaptureAndDeclarationScopes.	2 years ago
Siegfried Pammer	4bf9487ecd	Remove IsRef, IsOut and IsIn flags from IParameter and Replace ParameterModifiers with ReferenceKind.	2 years ago
Siegfried Pammer	ca78d4a14d	Use MetadataFile instead of PEFile in TypeSystem.	3 years ago
Siegfried Pammer	bde782e4f5	Fix #2806 : Do not use implicitly typed out variables, if argument and parameter types do not match exactly.	4 years ago
Siegfried Pammer	a9c8f86abc	Make TypeDef-ctor of FindTypeDecoder internal.	5 years ago
Siegfried Pammer	8cc0bf8b49	Generalize FindTypeDecoder	5 years ago
Siegfried Pammer	66850e4725	Fix #2270 : I love deleting code that causes problems and no longer makes any sense at all!	6 years ago
Siegfried Pammer	d3b0e4cd72	Fix #2196 : Add support for extern local functions.	6 years ago
Siegfried Pammer	3a7c69e5b9	Fix #2192 : Add support for VB.NET delegate construction	6 years ago
Siegfried Pammer	41edef710e	Fix build.	6 years ago
Siegfried Pammer	0b0a6d94a8	Add support for local function pointers.	6 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Siegfried Pammer	8d72672e6c	Reimplement DecompilerSettings.StaticLocalFunctions (was lost in the refactoring in #2077 )	6 years ago
Siegfried Pammer	18ace00266	Refactor LocalFunctionDeclarationStatement + LocalFunctionMethod	6 years ago
Daniel Grunwald	2acc4339df	#2058 : Mark most transforms as public to help users that use the ILAst directly without decompiling to C#.	6 years ago
Siegfried Pammer	74101ff0dc	Fix #2053 : Assert and NRE in LocalFunctionDecompiler	6 years ago
Siegfried Pammer	fcc910cb4d	Cleanup and refactoring after code review	6 years ago
Siegfried Pammer	0d1b6203df	#1981 : Refactor LocalFunctionDecompiler: Propagate closure parameter arguments, so that all arguments can be stripped from use-sites.	6 years ago
Siegfried Pammer	28391c4864	Fix #1895 : local function not added to the correct parent function.	7 years ago
Siegfried Pammer	f831e4713f	Fix #1867 : Captures of copies of this are not properly handled by the decompiler	7 years ago
Siegfried Pammer	5be6be97df	Code review: * rename a few identifiers, * add comments, * skip all compiler-generated type-arguments in resolve result, * and change implementation of LocalFunctionMethod.Specialize: wrap specialized method and not the other way round.	7 years ago
Siegfried Pammer	9e89384916	Make NumberOfCompilerGeneratedGenerics immutable and rename to NumberOfCompilerGeneratedTypeParameters	7 years ago
Siegfried Pammer	e189ad9ca3	Fix #1863 : Invalid decompilation: accessibility level for CompilerGenerated method	7 years ago
SilverFox	a5d85fea3f	Add an workaround for #1798	7 years ago
SilverFox	33f96fd888	Fix tests `LocalFunctions.NestedCapture1`	7 years ago
SilverFox	5e6fecebf5	Rework support for generic local function, and fix tests `LocalFunctions.Generic.Test_CaptureT` and `LocalFunctions.Generic.TestGenericArgs`	7 years ago
SilverFox	e60f1f5a87	Skip LocalFunctionDecompiler if the top scope is LocalFunction or LocalFunctionDisplayClass	7 years ago
SilverFox	f039705704	Add support for generic local function	7 years ago
Siegfried Pammer	76a8a4449c	#1671 : Do not crash if a generic local function is encountered. Emit warning instead.	7 years ago
Siegfried Pammer	4246a178f4	Remove unused parameter.	7 years ago
Siegfried Pammer	fdf4228a17	Fix #1623 : Nest local functions correctly, if captured variables are used.	7 years ago
Siegfried Pammer	3ad8c88d39	Fix #1622 : Transform local functions calls with named arguments correctly	7 years ago
Siegfried Pammer	0ca5ace524	#1349 : Fix assertions triggered by incorrect local function decompilation.	7 years ago
Siegfried Pammer	f10ab69328	Improve local-function detection to minimize false positives.	7 years ago
Siegfried Pammer	a109b77858	Refactor LocalFunctionDecompiler to allow mutually recursive local functions to be decompiled correctly.	7 years ago
Siegfried Pammer	e215f69b2d	Extend description of LocalFunctionDecompiler	7 years ago
Siegfried Pammer	37e14f43e3	Refactor/Clean up local functions representation in type system.	7 years ago
Siegfried Pammer	f3f38783df	ICSharpCode.Decompiler roundtrip test now completes	7 years ago
Daniel Grunwald	ccdabf2325	Fix a bunch of XmlDoc compiler warnings.	7 years ago
Siegfried Pammer	01e42b772c	Fix local functions inside lambdas.	7 years ago
Siegfried Pammer	305b47245e	Refactor representation of local functions in ILAst.	7 years ago
Siegfried Pammer	16d6e16da7	Add support for local function references and recursive local functions.	7 years ago

1 2

55 Commits (05d274ff727ebbef447bc01b0028299839aee6cf)