ILSpy

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	2115bd9028	Read the file system once per reference closure, not per reference Resolving one assembly resolves its whole reference closure, and every reference in it asked the same framework directories the same questions. The worst of it was the scan for the closest version folder of a shared framework: a directory listing plus a recursive file search, repeated per reference and per runtime pack - 42 scans for two distinct answers when decompiling ICSharpCode.ILSpyX.dll. The scan result is only safe to keep for a bounded time: a runtime can be installed or removed while ILSpy runs, and reloading an assembly list has to see that. So it is kept for the length of an explicitly opened scope, which the type system opens around the closure it resolves and closes again afterwards; outside a scope the file system is read as before. The scope owns what was read, so two of them on one resolver do not stack - the first to end takes it, and the other reads the file system again. BeginSnapshot is on IAssemblyResolver rather than an interface of its own: it is core functionality of a resolver, and one implementation is not an abstraction. This breaks the interface for implementors outside this repository, who opt out by returning null - which is what the three resolvers here that hold nothing do. The remaining probes cost nothing to fix: the preferred runtime pack was listed among the defaults it already belongs to, so its directory was scanned twice for every reference that is not in it, and one package folder was probed once per assembly the package contains. Measured over 27 references with a fresh resolver each time: 3.3 ms per assembly before, 3.1 ms without a scope, 1.1 ms with one. Assisted-by: Claude:claude-opus-5:Claude Code	2 weeks ago
Siegfried Pammer	317e33b3b8	Fix five small analyzer warnings. * ExtensionDeclaration.SymbolKind (CA1065) — was throwing NotImplementedException; return SymbolKind.TypeDefinition to match TypeDeclaration / DelegateDeclaration, since `extension` declarations are type-level. * CustomAttribute.DecodeValue (CA2002) — replace `lock(this)` on the sealed-but-internal class with a private syncRoot field. * PlainTextOutput (CA1001) — implement IDisposable; track an ownsWriter flag so we only dispose the underlying TextWriter when the parameterless constructor created its own StringWriter. * DotNetCorePathFinder (CA1060) — move the libc realpath / free PInvokes into a private nested NativeMethods class. * ILSpy.ReadyToRun (CA1016) — add [assembly: AssemblyVersion("1.0.0.0")] in Properties/AssemblyInfo.cs to match the BamlDecompiler plugin. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	4 months ago
Peter Crabtree	e1e16b64f5	dev: Strip BOM mark from text files	1 year ago
Herrmannsdörfer, Felix	0330f38c06	Include Subdirectories when checking for empty dotnet version directory	2 years ago
Herrmannsdörfer, Felix	63c2bb0b18	Ignore empty version directories of dotnet	2 years ago
Siegfried Pammer	26c9df5d03	Fix #3090 : add support for the NUGET_PACKAGES environment variable	3 years ago
Siegfried Pammer	518ade7523	Make GetReferenceAssemblyPath pick the closest available version.	5 years ago
Siegfried Pammer	35ad7f3074	Update build tools used by ILSpy to use .NET 5.0 instead of .NET Core 3.1	5 years ago
Siegfried Pammer	0ae95333e5	Fix bug in DotNetCorePathFinder on Unix systems: realpath always returned garbage.	5 years ago
Siegfried Pammer	5734da4294	Fix #2314 : ILSpy incorrectly resolves a runtime dependency when dll is present in both WindowsDesktop.App and NETCore.App	6 years ago
Siegfried Pammer	ea699b0da0	Fix formatting.	6 years ago
Bernd Baumanns	dd98de858d	ILSpy should not crash if fullName contains no "/" - no version info	6 years ago
文煌	d612008c9f	write OutputType for asp.net library	6 years ago
文煌	e8e0f89f6d	don't write HintPath for .NET Core shared assembly	6 years ago
dotnet format	0d9f871a4f	#2128 : Reformat the whole code base.	6 years ago
Siegfried Pammer	4b865c27e4	Fix #2076 : VS AddIn opens reference assembly.	6 years ago
Siegfried Pammer	4f8c588c7b	Fix #2068 : ILSpy can't find referenced library even though it's open	6 years ago
Siegfried Pammer	5f27fd9744	Fix DotNetCorePathFinder not finding assemblies in parent assembly base path.	6 years ago
Siegfried Pammer	0dfcafdfe8	Add preconfigured assembly list selection and rename command to ManageAssemblyListsDialog	6 years ago
Siegfried Pammer	805b83f43c	Fix DotNetCorePathFinder to properly support netstandard2.1	7 years ago
Siegfried Pammer	867d3d5755	Fix crash reported in #1820 : Change Dictionary<string, DotNetCorePackageInfo> to DotNetCorePackageInfo array, because key is no longer used.	7 years ago
Siegfried Pammer	84ca705250	Fix #1750 : DotNetCorePathFinder should not crash if a package is missing Fix #1757: Error decompiling .NET Core 3.0 assembly in Linux	7 years ago
Siegfried Pammer	981401a206	Fix #1750 : DotNetCorePathFinder should not crash if a package is missing Fix #1757: Error decompiling .NET Core 3.0 assembly in Linux	7 years ago
Siegfried Pammer	3b0402b381	Fix assembly resolving and Tester for .NET Core 3.0	7 years ago
Siegfried Pammer	e80a4a2f5c	Use .NET Core 3.0 in Unit Tests Roslyn config.	7 years ago
Andreas Weizel	c12b5d60ec	Resolve framework assemblies from more .NET Core runtime packs, like "Microsoft.WindowsDesktop.App" etc.	7 years ago
Siegfried Pammer	7befbb659c	#1300 : Fix resolver bug in DotNetCorePathFinder	8 years ago
Siegfried Pammer	3d68da7237	Improve parsing of TargetFramework attribute in UniversalAssemblyResolver.	8 years ago
Siegfried Pammer	e6e03a40d4	Move PEFile and other classes to different files, cleanup	8 years ago
Siegfried Pammer	87ced033ba	Rename Dom -> Metadata; Remove bogus abstraction	9 years ago
Siegfried Pammer	cb9787098f	Finished port of UI (Analyzers still excluded) and Disassembler	9 years ago
Siegfried Pammer	f493f5e606	Fail with null value instead of other exception in case of invalid json file.	9 years ago
Siegfried Pammer	151fa73e29	Fix exception in LoadPackageInfos	9 years ago
Siegfried Pammer	0e0291a113	Refactoring of LookupReferencedAssemblyInternal	9 years ago
Siegfried Pammer	aff91cf806	DotNetCore/DotNetCorePathFinder: improve FallbackToDotNetSharedDirectory	9 years ago
Siegfried Pammer	79835afca4	DotNetCore: include LightJson; remove Newtonsoft.Json	9 years ago
Siegfried Pammer	be667dee25	Fix x-plat bugs in DotNetCore/DotNetCorePathFinder	9 years ago
Siegfried Pammer	79ef84426a	Fix possible bug in DotNetCorePathFinder.	9 years ago
Siegfried Pammer	ebfc6cdcc2	Fix possible NRE in DotNetCorePathFinder	9 years ago
Siegfried Pammer	4626ba3fc8	Do not treat missing deps.json file as error. - Fixes #908 : Assembly loader issue (very minor)	9 years ago
Siegfried Pammer	4926e3ce24	Refactor FindDotNetExeDirectory	9 years ago
Siegfried Pammer	7ec5156f16	Add some loading information to AssemblyReferenceTreeNode/ReferenceFolderTreeNode.	9 years ago
Siegfried Pammer	0644de6fd3	Rip out LogWindow and DecompilerEventSource	9 years ago
Siegfried Pammer	d4581a477c	Add FindDotNetExeDirectory	9 years ago
Siegfried Pammer	7df1b2908d	Basic implementation of DotNetCorePathFinder	9 years ago

32 Commits (052aec9b89a8d79a50cb176b2a162c2ce676dafa)