ILSpy

9330 Commits

54 Branches

94 Tags

91 MiB

Branch: tests/829-lambda-param-modifiers

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	a9d0d1573a	Scroll bookmark navigation to the re-anchored line, not the saved offset After scrolling to a navigated bookmark, the deferred apply restored the caret/scroll captured when the bookmark was created, which overwrote the centering that had just been computed for the resolved line. A bookmark re-anchors by token / IL offset, so a decompiler-setting change that reflows the C# moves it to a different line than the one saved in its view state; the stale offset then scrolled that line back off-screen, leaving only the highlight playing where it could not be seen. Restore just the captured foldings now -- and before centering, since collapsing or expanding shifts where lines sit -- and let the centered, re-resolved line be the final caret and scroll position. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Siegfried Pammer	cabe7bf458	Position bookmark navigation from non-decompiler active content Activating a bookmark only positioned the view when a decompiler tab was already the active content: the pending bookmark was set on DockWorkspace.ActiveDecompilerTab, which is null while a metadata table, the Options page, or the About page is showing. Navigating from there selected and decompiled the node but opened at the top with no line highlight. The pending bookmark now travels to the decompiler model that ShowSelectedNode routes the selection to, and is consumed in the document-apply step alongside the view-state restore -- mirroring PendingViewState -- rather than reacting to a property change. The earlier property-change path fired synchronously during selection, scrolled, then a deferred document apply reset the caret to the top with nothing left to re-apply. For a node that is already decompiled (re-shown after an interlude, where no apply step runs) a ScrollToBookmark callback on the model scrolls the live view directly, mirroring NavigateBookmarkInFile. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago

Author

SHA1

Message

Date

Siegfried Pammer

a9d0d1573a

Scroll bookmark navigation to the re-anchored line, not the saved offset

After scrolling to a navigated bookmark, the deferred apply restored the
caret/scroll captured when the bookmark was created, which overwrote the
centering that had just been computed for the resolved line. A bookmark
re-anchors by token / IL offset, so a decompiler-setting change that reflows
the C# moves it to a different line than the one saved in its view state; the
stale offset then scrolled that line back off-screen, leaving only the
highlight playing where it could not be seen.

Restore just the captured foldings now -- and before centering, since
collapsing or expanding shifts where lines sit -- and let the centered,
re-resolved line be the final caret and scroll position.

Assisted-by: Claude:claude-opus-4-8:Claude Code

3 months ago

Siegfried Pammer

cabe7bf458

Position bookmark navigation from non-decompiler active content

Activating a bookmark only positioned the view when a decompiler tab was
already the active content: the pending bookmark was set on
DockWorkspace.ActiveDecompilerTab, which is null while a metadata table, the
Options page, or the About page is showing. Navigating from there selected and
decompiled the node but opened at the top with no line highlight.

The pending bookmark now travels to the decompiler model that ShowSelectedNode
routes the selection to, and is consumed in the document-apply step alongside
the view-state restore -- mirroring PendingViewState -- rather than reacting to
a property change. The earlier property-change path fired synchronously during
selection, scrolled, then a deferred document apply reset the caret to the top
with nothing left to re-apply. For a node that is already decompiled (re-shown
after an interlude, where no apply step runs) a ScrollToBookmark callback on the
model scrolls the live view directly, mirroring NavigateBookmarkInFile.

Assisted-by: Claude:claude-opus-4-8:Claude Code

3 months ago

2 Commits (tests/829-lambda-param-modifiers)