ILSpy

9792 Commits

54 Branches

94 Tags

91 MiB

Branch: master

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	d8dfbec04b	Write XAML a XAML parser can read back Two of the defects reported on issue #2253 come from the decompiler writing text that means something else when it is read again. A markup extension is written as a single attribute value, and its grammar gives ',' '=' '{' '}' and the quote characters a meaning. Values went out unquoted, so an argument carrying any of them was read back as further name/value pairs: {DXBinding Expr='Price - Prev > 0 ? ...'}, the reported case, no longer compiles at all (MC3042, MC3045). Values without such a character stay unquoted, because quoting them would rewrite every document that never needed it. A clr-namespace declaration names the CLR namespace it maps, but nothing read that name out of it, so no lookup by namespace could match a declaration the document itself had made. Every type in such a namespace then got a second prefix declared on the element that used it. The assembly is the second half of the same lookup, and there the document records the name it was written against while a well-known type carries the assembly it resolves to now - "mscorlib" against "System.Private.CoreLib" - so the two are also accepted as the same when the recorded assembly forwards the type. Assisted-by: Claude:claude-opus-5:Claude Code	2 weeks ago
Siegfried Pammer	f1bc6ab542	Fix #1688 : resolve elements to the XML namespace the document declares An assembly can map one CLR namespace to several XML namespaces: PresentationFramework maps its namespaces to both the winfx/2006 and the netfx/2007 presentation namespace. The fallback used when the BAML xmlns records name no namespace for a type always preferred the winfx/2006 one, so a document that binds the default prefix to netfx/2007 ended up with a root start tag that declares one presentation namespace and needs the other for its own name, which XmlWriter rejects. Only the root carries the xmlns declaration, which is why skipping XClassRewritePass worked around it. Assisted-by: Claude:claude-opus-5:Claude Code	2 weeks ago
Siegfried Pammer	5343d849d4	Revive BAML decompiler tests as two projects and run them in CI The BAML tests were orphaned: in no solution, no CI, and missing their ICSharpCode.BamlDecompiler reference. Revive them split by platform, mirroring ILSpy.Tests / ILSpy.Tests.Windows: ILSpy.BamlDecompiler.Tests (net11.0) holds platform-agnostic tests - including a regression test that decompiles with the WPF assemblies hidden, covering the missing-assembly fix - and ILSpy.BamlDecompiler.Tests.Windows (net11.0-windows) holds the WPF round-trip cases that compile XAML into BAML. Single-TFM projects keep normal lock files; the Windows one declares all RIDs so its lock is generatable and verifiable on any host. Wire the cross-platform project into ILSpy.sln, ILSpy.XPlat.slnf and ILSpy.Desktop.slnf so it builds and runs on the Linux/macOS legs; the Windows project stays in ILSpy.sln (its tests execute in the Windows leg). The Windows job also archives that assembly, whose embedded BAML lets the decompiler be exercised against real BAML on a host without WPF. Assisted-by: Claude:claude-opus-4-8:Claude Code	2 months ago

Author

SHA1

Message

Date

Siegfried Pammer

d8dfbec04b

Write XAML a XAML parser can read back

Two of the defects reported on issue #2253 come from the decompiler
writing text that means something else when it is read again.

A markup extension is written as a single attribute value, and its
grammar gives ',' '=' '{' '}' and the quote characters a meaning. Values
went out unquoted, so an argument carrying any of them was read back as
further name/value pairs: {DXBinding Expr='Price - Prev > 0 ? ...'}, the
reported case, no longer compiles at all (MC3042, MC3045). Values without
such a character stay unquoted, because quoting them would rewrite every
document that never needed it.

A clr-namespace declaration names the CLR namespace it maps, but nothing
read that name out of it, so no lookup by namespace could match a
declaration the document itself had made. Every type in such a namespace
then got a second prefix declared on the element that used it. The
assembly is the second half of the same lookup, and there the document
records the name it was written against while a well-known type carries
the assembly it resolves to now - "mscorlib" against
"System.Private.CoreLib" - so the two are also accepted as the same when
the recorded assembly forwards the type.

Assisted-by: Claude:claude-opus-5:Claude Code

2 weeks ago

Siegfried Pammer

f1bc6ab542

Fix #1688 : resolve elements to the XML namespace the document declares

An assembly can map one CLR namespace to several XML namespaces: PresentationFramework
maps its namespaces to both the winfx/2006 and the netfx/2007 presentation namespace. The
fallback used when the BAML xmlns records name no namespace for a type always preferred the
winfx/2006 one, so a document that binds the default prefix to netfx/2007 ended up with a
root start tag that declares one presentation namespace and needs the other for its own
name, which XmlWriter rejects. Only the root carries the xmlns declaration, which is why
skipping XClassRewritePass worked around it.

Assisted-by: Claude:claude-opus-5:Claude Code

2 weeks ago

Siegfried Pammer

5343d849d4

Revive BAML decompiler tests as two projects and run them in CI

The BAML tests were orphaned: in no solution, no CI, and missing their
ICSharpCode.BamlDecompiler reference. Revive them split by platform,
mirroring ILSpy.Tests / ILSpy.Tests.Windows: ILSpy.BamlDecompiler.Tests
(net11.0) holds platform-agnostic tests - including a regression test that
decompiles with the WPF assemblies hidden, covering the missing-assembly
fix - and ILSpy.BamlDecompiler.Tests.Windows (net11.0-windows) holds the
WPF round-trip cases that compile XAML into BAML. Single-TFM projects keep
normal lock files; the Windows one declares all RIDs so its lock is
generatable and verifiable on any host.

Wire the cross-platform project into ILSpy.sln, ILSpy.XPlat.slnf and
ILSpy.Desktop.slnf so it builds and runs on the Linux/macOS legs; the
Windows project stays in ILSpy.sln (its tests execute in the Windows leg).
The Windows job also archives that assembly, whose embedded BAML lets the
decompiler be exercised against real BAML on a host without WPF.

Assisted-by: Claude:claude-opus-4-8:Claude Code

2 months ago

3 Commits (master)