ILSpy

9782 Commits

54 Branches

94 Tags

91 MiB

Branch: ldmembertoken

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	3ec7e5f820	Cover the field-keyword name collisions with fixtures Two paths generate a local named "field" inside an accessor - a local typed after a class named Field, and one named after the GetField method it is assigned from - and C# 14 rejects that identifier there (CS9273). Worse than the compile error, the local shadows the keyword, so a backing-field read silently becomes a read of the local; both paths now have a fixture, verified to regress without the name reservation. A static member named "field" cannot be disambiguated with "this.", so the accessor has to name its declaring type; that path had no coverage either. Assisted-by: Claude:claude-opus-5:Claude Code	1 month ago
Siegfried Pammer	3da129632e	Fix #3624 : decompile semi-auto properties with the C# 14 field keyword Backing-field references inside a property's own get/set/init accessors are emitted as the `field` keyword at IL-to-AST translation time (ExpressionBuilder.ConvertField), so arbitrary accessor bodies become expressible and no separate rewrite pass is needed. Compiler-generated trivial accessors then collapse individually to `get;`/`set;`, which also handles mixed shapes like `{ get; set { ... field ... } }`; the backing-field declaration is removed with its remaining attributes re-hosted as `field:` sections, and constructor stores become property initializers (or property assignments, for setter-less properties). Implicit zero-stores that auto-default struct constructors emit for unassigned backing fields are dropped rather than lifted. Recognition stays AST/metadata-based rather than mirroring the ILAst analysis used for automatic events: events must prove compiler-generated bodies before discarding them, while the field keyword discards nothing, so name association plus the accessor context is sufficient. Below C# 14 (or with the new FieldKeyword setting off), the field declaration survives under its metadata name, so the UI keeps showing the truth; EscapeInvalidIdentifiers - the transform the compilable-output flows (project export, VS, tests) already add - now maps `<P>k__BackingField` to the readable `P__BackingField` instead of the generic character escape. A genuine field literally named "field" is qualified as `this.field` inside accessors, and locals are not named "field" there, since C# 14 rebinds the bare identifier. Bodiless accessors mixed into multi-line properties get their own line in the output. The fixture covering the feature surface lands with the implementation rather than as a separate xfailed commit. It is excluded from the test-assembly compilation because its nullable annotations would trip warnings-as-errors there. Assisted-by: Claude:claude-fable-5:Claude Code	1 month ago

Author

SHA1

Message

Date

Siegfried Pammer

3ec7e5f820

Cover the field-keyword name collisions with fixtures

Two paths generate a local named "field" inside an accessor - a local
typed after a class named Field, and one named after the GetField method
it is assigned from - and C# 14 rejects that identifier there (CS9273).
Worse than the compile error, the local shadows the keyword, so a
backing-field read silently becomes a read of the local; both paths now
have a fixture, verified to regress without the name reservation.

A static member named "field" cannot be disambiguated with "this.", so
the accessor has to name its declaring type; that path had no coverage
either.

Assisted-by: Claude:claude-opus-5:Claude Code

1 month ago

Siegfried Pammer

3da129632e

Fix #3624 : decompile semi-auto properties with the C# 14 field keyword

Backing-field references inside a property's own get/set/init accessors
are emitted as the `field` keyword at IL-to-AST translation time
(ExpressionBuilder.ConvertField), so arbitrary accessor bodies become
expressible and no separate rewrite pass is needed. Compiler-generated
trivial accessors then collapse individually to `get;`/`set;`, which
also handles mixed shapes like `{ get; set { ... field ... } }`; the
backing-field declaration is removed with its remaining attributes
re-hosted as `field:` sections, and constructor stores become property
initializers (or property assignments, for setter-less properties).
Implicit zero-stores that auto-default struct constructors emit for
unassigned backing fields are dropped rather than lifted.

Recognition stays AST/metadata-based rather than mirroring the ILAst
analysis used for automatic events: events must prove compiler-generated
bodies before discarding them, while the field keyword discards nothing,
so name association plus the accessor context is sufficient.

Below C# 14 (or with the new FieldKeyword setting off), the field
declaration survives under its metadata name, so the UI keeps showing
the truth; EscapeInvalidIdentifiers - the transform the compilable-output
flows (project export, VS, tests) already add - now maps
`<P>k__BackingField` to the readable `P__BackingField` instead of the
generic character escape. A genuine field literally named "field" is
qualified as `this.field` inside accessors, and locals are not named
"field" there, since C# 14 rebinds the bare identifier. Bodiless
accessors mixed into multi-line properties get their own line in the
output.

The fixture covering the feature surface lands with the implementation rather
than as a separate xfailed commit. It is excluded from the test-assembly
compilation because its nullable annotations would trip warnings-as-errors
there.

Assisted-by: Claude:claude-fable-5:Claude Code

1 month ago

2 Commits (ldmembertoken)