ILSpy

9782 Commits

54 Branches

94 Tags

91 MiB

Branch: ldmembertoken

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	d8aca3f113	Add an async/await pattern test suite for ExpressionBuilder.VisitAwait The await surface had almost no fixture coverage beyond Task/ValueTask: every GetAwaiter in the corpus was an instance method on the awaited type itself, so the conversion VisitAwait applies to the operand was never exercised for an inherited, interface-typed or extension-method awaiter. Probing that surface turned up eight defects, all of which produce C# that does not compile. AsyncAwaitPatterns pins the shapes that do round-trip, along the three axes the translation actually depends on: the GetAwaiter receiver, the operand expression, and the context the await sits in. Its Correctness twin pins what Pretty cannot see - copy semantics of struct awaitables and the evaluation order around the suspension point. AsyncAwaitPatternsBugs is the spec for the defects, written as the C# that ought to come out, with the current wrong output named per member. It fails today; that is the point, and fixing a defect is meant to delete a comment rather than edit an expectation. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	4 weeks ago

Author

SHA1

Message

Date

Siegfried Pammer

d8aca3f113

Add an async/await pattern test suite for ExpressionBuilder.VisitAwait

The await surface had almost no fixture coverage beyond Task/ValueTask: every
GetAwaiter in the corpus was an instance method on the awaited type itself, so
the conversion VisitAwait applies to the operand was never exercised for an
inherited, interface-typed or extension-method awaiter. Probing that surface
turned up eight defects, all of which produce C# that does not compile.

AsyncAwaitPatterns pins the shapes that do round-trip, along the three axes the
translation actually depends on: the GetAwaiter receiver, the operand
expression, and the context the await sits in. Its Correctness twin pins what
Pretty cannot see - copy semantics of struct awaitables and the evaluation
order around the suspension point.

AsyncAwaitPatternsBugs is the spec for the defects, written as the C# that
ought to come out, with the current wrong output named per member. It fails
today; that is the point, and fixing a defect is meant to delete a comment
rather than edit an expectation.

Assisted-by: Claude:claude-opus-5[1m]:Claude Code

4 weeks ago

1 Commits (ldmembertoken)