ILSpy

9645 Commits

54 Branches

94 Tags

91 MiB

Branch: fix/lambda-parameter-syntax

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	4bc51e6083	Drop isReferenceType when erasing unknown types Whether an unresolvable type is a reference type is not a property of the type but of the metadata that mentioned it: a signature spelling it `valuetype T` yields false, a bare TypeRef yields null. UnknownType.Equals compares the flag, so the two spellings of one missing type compared unequal and EquivalentTypes reported false - the decompiler then emitted a cast between a type and itself. Erasing the flag in NormalizeTypeVisitor keeps the relaxation inside the comparisons that ask for erasure, next to the nullability, modopt and tuple erasure that are use-site spellings of the same kind. Dropping the term from UnknownType.Equals instead was measured and rejected: Equals also keys CSharpConversions' implicit-conversion cache, where merging the two spellings lets whichever conversion is computed first answer for both, adding 398 boxing casts across two real-world assemblies. Assisted-by: Claude:claude-opus-5[1m]:Claude Code	3 weeks ago
Siegfried Pammer	ac8a8ff64d	Add an ILPretty test for #3729 Structs whose assembly is missing decompile through the unresolved-type path, which is not covered anywhere: the fixture pins the constructor shapes that path has to recognize, and the reference-type cases that must keep falling through to a plain call. Assisted-by: Claude:claude-opus-5:Claude Code	1 month ago

Author

SHA1

Message

Date

Siegfried Pammer

4bc51e6083

Drop isReferenceType when erasing unknown types

Whether an unresolvable type is a reference type is not a property of the
type but of the metadata that mentioned it: a signature spelling it
`valuetype T` yields false, a bare TypeRef yields null. UnknownType.Equals
compares the flag, so the two spellings of one missing type compared
unequal and EquivalentTypes reported false - the decompiler then emitted a
cast between a type and itself.

Erasing the flag in NormalizeTypeVisitor keeps the relaxation inside the
comparisons that ask for erasure, next to the nullability, modopt and tuple
erasure that are use-site spellings of the same kind. Dropping the term
from UnknownType.Equals instead was measured and rejected: Equals also keys
CSharpConversions' implicit-conversion cache, where merging the two
spellings lets whichever conversion is computed first answer for both,
adding 398 boxing casts across two real-world assemblies.

Assisted-by: Claude:claude-opus-5[1m]:Claude Code

3 weeks ago

Siegfried Pammer

ac8a8ff64d

Add an ILPretty test for #3729

Structs whose assembly is missing decompile through the unresolved-type
path, which is not covered anywhere: the fixture pins the constructor
shapes that path has to recognize, and the reference-type cases that must
keep falling through to a plain call.

Assisted-by: Claude:claude-opus-5:Claude Code

1 month ago

2 Commits (fix/lambda-parameter-syntax)