ILSpy

9656 Commits

54 Branches

94 Tags

91 MiB

Branch: fix/2040-invalid-xml-characters

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	75e7c61e93	Fix #2728 : render the MSVC C++/CLI ID string dialect MSVC documents C++/CLI members with ECMA-372-style ID strings that differ from Roslyn's in signatures: custom modifiers are rendered after the modified type (a 'const int' parameter becomes System.Int32!System.Runtime.CompilerServices.IsConst), arity markers stay on generic instantiations (List`1{System.Int32}.Enumerator), and the default indexed property is called 'default'. Roslyn ignores modifiers entirely, so one generated string cannot match both compilers' xml files: GetIdString keeps producing the C#/Roslyn form, and the new GetIdStringCandidates additionally yields the C++/CLI form, most specific first, for lookup code to try in order. The dialect is pinned by IdStringProbe.il/.xml, the trimmed disassembly of an MSVC-compiled probe assembly together with the unmodified xml MSVC generated for it. Notable observed deviations from MSVC's documented format: modreq is generated, but only modreq(IsVolatile) uses the documented '\|'; modreq(IsByValue) on conversion operator operands is rendered with '!'. Assisted-by: Claude:claude-fable-5:Claude Code	2 months ago

Author

SHA1

Message

Date

Siegfried Pammer

75e7c61e93

Fix #2728 : render the MSVC C++/CLI ID string dialect

MSVC documents C++/CLI members with ECMA-372-style ID strings that
differ from Roslyn's in signatures: custom modifiers are rendered after
the modified type (a 'const int' parameter becomes
System.Int32!System.Runtime.CompilerServices.IsConst), arity markers
stay on generic instantiations (List`1{System.Int32}.Enumerator), and
the default indexed property is called 'default'. Roslyn ignores
modifiers entirely, so one generated string cannot match both
compilers' xml files: GetIdString keeps producing the C#/Roslyn form,
and the new GetIdStringCandidates additionally yields the C++/CLI form,
most specific first, for lookup code to try in order.

The dialect is pinned by IdStringProbe.il/.xml, the trimmed disassembly
of an MSVC-compiled probe assembly together with the unmodified xml MSVC
generated for it. Notable observed deviations from MSVC's documented
format: modreq is generated, but only modreq(IsVolatile) uses the
documented '|'; modreq(IsByValue) on conversion operator operands is
rendered with '!'.

Assisted-by: Claude:claude-fable-5:Claude Code

2 months ago

1 Commits (fix/2040-invalid-xml-characters)