ILSpy

9405 Commits

54 Branches

94 Tags

91 MiB

Branch: fix/1982-params-attribute-args

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	51aafa0fd9	Move ILSpy UI code back to the ICSharpCode.ILSpy root namespace The Avalonia port had placed the UI app in an ILSpy.* namespace tree, while the csproj RootNamespace and every prior release (through 10.1) use ICSharpCode.ILSpy.*. Restoring the historical namespace reduces the public API diff against release/10.1 for plugin authors and removes the shadowing that forced global:: qualifiers in the test project. The Images class and AccessOverlayIcon enum move back into the root namespace (as in 10.1), since an ICSharpCode.ILSpy.Images namespace would shadow the Images class for all code inside ICSharpCode.ILSpy. Assisted-by: Claude:claude-fable-5:Claude Code	3 months ago
Siegfried Pammer	61bd014c2d	Land external file drops anywhere on the assembly tree Two failure modes that both showed the user the "no" cursor with no other feedback: 1. ResolveDropTarget returned null when e.Source had no SharpTreeViewItem ancestor, so Explorer drops landing in the gap beneath the last row (or onto an empty list) never reached SharpTreeNode.InternalDrop. 2. The middle 50% of a row produces a DropPlace.Inside target on the row's own node. Most concrete SharpTreeNodes inherit the base CanDrop (returns false), so a literal "drop a .dll onto an assembly row" refused even though AssemblyListTreeNode happily accepts that payload. For (1), fall back to (Root, Children.Count, DropPlace.Inside) when no row is hit. For (2), introduce PickAcceptingTarget which retries with the empty-space (root) target when the initial CanDrop is false. Both OnDragOver and OnDrop go through the same picker so the cursor and the actual drop agree on the outcome. The retry skips when the initial target already IS the root, so a real refusal still surfaces as "no". The marker adorner stays hidden for empty-space drops because the place is always Inside (Item is null for that case); the existing DropPlace.Inside early return covers it. DropTarget, DropPlace, and the two new helpers are internal-visible to the ILSpy.Tests project for the unit tests that assert the fallback chain. Assisted-by: Claude:claude-opus-4-7[1m]:Claude Code	3 months ago

Author

SHA1

Message

Date

Siegfried Pammer

51aafa0fd9

Move ILSpy UI code back to the ICSharpCode.ILSpy root namespace

The Avalonia port had placed the UI app in an ILSpy.* namespace tree,
while the csproj RootNamespace and every prior release (through 10.1)
use ICSharpCode.ILSpy.*. Restoring the historical namespace reduces the
public API diff against release/10.1 for plugin authors and removes the
shadowing that forced global:: qualifiers in the test project. The
Images class and AccessOverlayIcon enum move back into the root
namespace (as in 10.1), since an ICSharpCode.ILSpy.Images namespace
would shadow the Images class for all code inside ICSharpCode.ILSpy.

Assisted-by: Claude:claude-fable-5:Claude Code

3 months ago

Siegfried Pammer

61bd014c2d

Land external file drops anywhere on the assembly tree

Two failure modes that both showed the user the "no" cursor with no
other feedback:

1. ResolveDropTarget returned null when e.Source had no
SharpTreeViewItem ancestor, so Explorer drops landing in the gap
beneath the last row (or onto an empty list) never reached
SharpTreeNode.InternalDrop.

2. The middle 50% of a row produces a DropPlace.Inside target on the
row's own node. Most concrete SharpTreeNodes inherit the base CanDrop
(returns false), so a literal "drop a .dll onto an assembly row"
refused even though AssemblyListTreeNode happily accepts that payload.

For (1), fall back to (Root, Children.Count, DropPlace.Inside) when no
row is hit. For (2), introduce PickAcceptingTarget which retries with
the empty-space (root) target when the initial CanDrop is false. Both
OnDragOver and OnDrop go through the same picker so the cursor and the
actual drop agree on the outcome. The retry skips when the initial
target already IS the root, so a real refusal still surfaces as "no".

The marker adorner stays hidden for empty-space drops because the
place is always Inside (Item is null for that case); the existing
DropPlace.Inside early return covers it.

DropTarget, DropPlace, and the two new helpers are internal-visible to
the ILSpy.Tests project for the unit tests that assert the fallback
chain.

Assisted-by: Claude:claude-opus-4-7[1m]:Claude Code

3 months ago

2 Commits (fix/1982-params-attribute-args)