ILSpy

9405 Commits

54 Branches

94 Tags

91 MiB

Branch: fix/1982-params-attribute-args

Commit Graph

Author	SHA1	Message	Date
Siegfried Pammer	853220dba9	Cover more constructs in the PDB sequence-point tests Extends the breakpoint-map comparison to hidden sequence points, anchoring each hidden point to the visible point it follows so the descriptor stays independent of the IL offsets the decompiler reconstructs. Adds PdbGen cases spanning try/catch/finally, switch, async/await, yield, loops, LINQ, pattern matching and more, pinning the known residuals where the decompiler folds a compiler-hidden branch into an adjacent point. Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Siegfried Pammer	182fb4e814	Compare PDB sequence points against the compiler's breakpoint map The PdbGen tests compared the reconstructed PDB to the C# compiler's byte-for-byte, so any non-trivial method failed on reconstructed IL ranges, hidden sequence points and local scopes - none of which the decompiler can reproduce exactly. That left four of seven fixtures [Ignore]d and the suite with almost no coverage. Compare only what a debugging user actually feels: the visible (non-hidden) breakpoint map, parsed straight from the sequence-point blobs and keyed by method-definition row (shared between the PDB and the PE it describes). IL offsets, hidden points, local scopes and the embedded source are dropped. The compiler's own PDB is the oracle, so the tests assert correct debugging behavior rather than the decompiler's past output. Methods where the decompiler legitimately diverges pin an auto-derived residual snapshot, the same accept-the-diff workflow as the pretty tests; a separate oracle-free check rejects duplicate or overlapping sequence points. Un-ignores ForLoopTests, LambdaCapturing and Members (its source is regenerated to match the decompiler's per-type output, collapsing ~50 lines of indentation-induced coordinate noise to two genuine differences). Assisted-by: Claude:claude-opus-4-8:Claude Code	3 months ago
Kirill Osenkov	5f2b8e6098	Add a disabled test for sequence points in all members	3 years ago

Author

SHA1

Message

Date

Siegfried Pammer

853220dba9

Cover more constructs in the PDB sequence-point tests

Extends the breakpoint-map comparison to hidden sequence points, anchoring
each hidden point to the visible point it follows so the descriptor stays
independent of the IL offsets the decompiler reconstructs. Adds PdbGen cases
spanning try/catch/finally, switch, async/await, yield, loops, LINQ, pattern
matching and more, pinning the known residuals where the decompiler folds a
compiler-hidden branch into an adjacent point.

Assisted-by: Claude:claude-opus-4-8:Claude Code

3 months ago

Siegfried Pammer

182fb4e814

Compare PDB sequence points against the compiler's breakpoint map

The PdbGen tests compared the reconstructed PDB to the C# compiler's
byte-for-byte, so any non-trivial method failed on reconstructed IL
ranges, hidden sequence points and local scopes - none of which the
decompiler can reproduce exactly. That left four of seven fixtures
[Ignore]d and the suite with almost no coverage.

Compare only what a debugging user actually feels: the visible (non-hidden)
breakpoint map, parsed straight from the sequence-point blobs and keyed by
method-definition row (shared between the PDB and the PE it describes). IL
offsets, hidden points, local scopes and the embedded source are dropped.
The compiler's own PDB is the oracle, so the tests assert correct debugging
behavior rather than the decompiler's past output. Methods where the
decompiler legitimately diverges pin an auto-derived residual snapshot, the
same accept-the-diff workflow as the pretty tests; a separate oracle-free
check rejects duplicate or overlapping sequence points.

Un-ignores ForLoopTests, LambdaCapturing and Members (its source is
regenerated to match the decompiler's per-type output, collapsing ~50 lines
of indentation-induced coordinate noise to two genuine differences).

Assisted-by: Claude:claude-opus-4-8:Claude Code

3 months ago

Kirill Osenkov

5f2b8e6098

Add a disabled test for sequence points in all members

3 years ago

1 Commits (fix/1982-params-attribute-args)