From f42d72e799311ccbdf5595281c1ec3e52e866307 Mon Sep 17 00:00:00 2001 From: Siegfried Pammer Date: Thu, 5 Dec 2019 01:42:32 +0100 Subject: [PATCH] Fix #1805: Ignore exceptions thrown while trying to resolve an entity for rich text tooltips. --- .../Documentation/XmlDocumentationElement.cs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ICSharpCode.Decompiler/Documentation/XmlDocumentationElement.cs b/ICSharpCode.Decompiler/Documentation/XmlDocumentationElement.cs index 7f360b9ed..3b8b0f21e 100644 --- a/ICSharpCode.Decompiler/Documentation/XmlDocumentationElement.cs +++ b/ICSharpCode.Decompiler/Documentation/XmlDocumentationElement.cs @@ -91,8 +91,12 @@ namespace ICSharpCode.Decompiler.Documentation get { if (!referencedEntityInitialized) { string cref = GetAttribute("cref"); - if (!string.IsNullOrEmpty(cref) && crefResolver != null) - referencedEntity = crefResolver(cref); + try { + if (!string.IsNullOrEmpty(cref) && crefResolver != null) + referencedEntity = crefResolver(cref); + } catch { + referencedEntity = null; + } referencedEntityInitialized = true; } return referencedEntity; @@ -113,7 +117,7 @@ namespace ICSharpCode.Decompiler.Documentation /// public string GetAttribute(string name) { - return element?.Attribute(name)?.Value ?? string.Empty; + return element?.Attribute(name)?.Value; } ///