Browse Source

Removed redundant code in type 'used-by' analyzer

pull/569/head
Ed Harvey 10 years ago
parent
commit
ba12fb0742
  1. 28
      ILSpy/TreeNodes/Analyzer/AnalyzedTypeUsedByTreeNode.cs

28
ILSpy/TreeNodes/Analyzer/AnalyzedTypeUsedByTreeNode.cs

@ -60,7 +60,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer @@ -60,7 +60,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer
if (IsUsedInTypeDefinition(type))
yield return new AnalyzedTypeTreeNode(type) { Language = Language };
foreach (var field in type.Fields.Where(IsUsedInFieldDefinition))
foreach (var field in type.Fields.Where(IsUsedInFieldReference))
yield return new AnalyzedFieldTreeNode(field) { Language = Language };
foreach (var method in type.Methods.Where(IsUsedInMethodDefinition))
@ -94,8 +94,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer @@ -94,8 +94,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer
{
return IsUsedInTypeReference(type)
|| TypeMatches(type.BaseType)
|| IsUsedInTypeReferences(type.Interfaces)
|| IsUsedInCustomAttributes(type.CustomAttributes);
|| IsUsedInTypeReferences(type.Interfaces);
}
private bool IsUsedInFieldReference(FieldReference field)
@ -107,12 +106,6 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer @@ -107,12 +106,6 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer
|| TypeMatches(field.FieldType);
}
private bool IsUsedInFieldDefinition(FieldDefinition field)
{
return IsUsedInFieldReference(field)
|| IsUsedInCustomAttributes(field.CustomAttributes);
}
private bool IsUsedInMethodReference(MethodReference method)
{
if (method == null)
@ -126,8 +119,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer @@ -126,8 +119,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer
private bool IsUsedInMethodDefinition(MethodDefinition method)
{
return IsUsedInMethodReference(method)
|| IsUsedInMethodBody(method)
|| IsUsedInCustomAttributes(method.CustomAttributes);
|| IsUsedInMethodBody(method);
}
private bool IsUsedInMethodBody(MethodDefinition method)
@ -167,19 +159,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer @@ -167,19 +159,7 @@ namespace ICSharpCode.ILSpy.TreeNodes.Analyzer
private bool IsUsedInMethodParameter(ParameterDefinition parameter)
{
return TypeMatches(parameter.ParameterType)
|| IsUsedInCustomAttributes(parameter.CustomAttributes);
}
private bool IsUsedInCustomAttributes(IEnumerable<CustomAttribute> attributes)
{
return attributes.Any(IsUsedInCustomAttribute);
}
private bool IsUsedInCustomAttribute(CustomAttribute attribute)
{
// No need search in custom attribute, ILSpy already provide an "Applied To" search.
return false;
return TypeMatches(parameter.ParameterType);
}
private bool TypeMatches(TypeReference tref)

Loading…
Cancel
Save