From f0c71fc9fa7a5c8fd13c5fd3b099ae1508f1bae2 Mon Sep 17 00:00:00 2001 From: siriak Date: Sat, 29 Dec 2018 21:37:56 +0200 Subject: [PATCH 1/2] Fix 1362 Change string literals in favor of nameof usage --- ILSpy/FilterSettings.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/ILSpy/FilterSettings.cs b/ILSpy/FilterSettings.cs index b31c885f9..3c0f4521f 100644 --- a/ILSpy/FilterSettings.cs +++ b/ILSpy/FilterSettings.cs @@ -64,7 +64,7 @@ namespace ICSharpCode.ILSpy set { if (searchTerm != value) { searchTerm = value; - OnPropertyChanged("SearchTerm"); + OnPropertyChanged(nameof(SearchTerm)); } } } @@ -89,7 +89,7 @@ namespace ICSharpCode.ILSpy set { if (showApiLevel != value) { showApiLevel = value; - OnPropertyChanged("ShowApiLevel"); + OnPropertyChanged(nameof(ShowApiLevel)); } } } @@ -102,8 +102,8 @@ namespace ICSharpCode.ILSpy } else { ShowApiLevel = ApiVisibility.PublicAndInternal; } - OnPropertyChanged("ShowInternalApi"); - OnPropertyChanged("ShowAllApi"); + OnPropertyChanged(nameof(ShowInternalApi)); + OnPropertyChanged(nameof(ShowAllApi)); } } @@ -114,10 +114,10 @@ namespace ICSharpCode.ILSpy ShowApiLevel = ApiVisibility.PublicOnly; } else { ShowApiLevel = ApiVisibility.All; - } - OnPropertyChanged("ShowInternalApi"); - OnPropertyChanged("ShowAllApi"); - } + } + OnPropertyChanged(nameof(ShowInternalApi)); + OnPropertyChanged(nameof(ShowAllApi)); + } } Language language; From fea354816b82c9900ed264436ab388060f0913d6 Mon Sep 17 00:00:00 2001 From: siriak Date: Sun, 30 Dec 2018 21:35:59 +0200 Subject: [PATCH 2/2] Fix 1362 Remove string literals in favor of nameof(), fix mixed tabs --- ILSpy/AboutPage.cs | 4 ++-- ILSpy/FilterSettings.cs | 8 ++++---- ILSpy/LoadedNugetPackage.cs | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ILSpy/AboutPage.cs b/ILSpy/AboutPage.cs index 735ce2089..5bd1b40e8 100644 --- a/ILSpy/AboutPage.cs +++ b/ILSpy/AboutPage.cs @@ -236,7 +236,7 @@ namespace ICSharpCode.ILSpy if (automaticUpdateCheckEnabled != value) { automaticUpdateCheckEnabled = value; Save(); - OnPropertyChanged("AutomaticUpdateCheckEnabled"); + OnPropertyChanged(nameof(AutomaticUpdateCheckEnabled)); } } } @@ -249,7 +249,7 @@ namespace ICSharpCode.ILSpy if (lastSuccessfulUpdateCheck != value) { lastSuccessfulUpdateCheck = value; Save(); - OnPropertyChanged("LastSuccessfulUpdateCheck"); + OnPropertyChanged(nameof(LastSuccessfulUpdateCheck)); } } } diff --git a/ILSpy/FilterSettings.cs b/ILSpy/FilterSettings.cs index 3c0f4521f..9a76a6a26 100644 --- a/ILSpy/FilterSettings.cs +++ b/ILSpy/FilterSettings.cs @@ -114,10 +114,10 @@ namespace ICSharpCode.ILSpy ShowApiLevel = ApiVisibility.PublicOnly; } else { ShowApiLevel = ApiVisibility.All; - } - OnPropertyChanged(nameof(ShowInternalApi)); - OnPropertyChanged(nameof(ShowAllApi)); - } + } + OnPropertyChanged(nameof(ShowInternalApi)); + OnPropertyChanged(nameof(ShowAllApi)); + } } Language language; diff --git a/ILSpy/LoadedNugetPackage.cs b/ILSpy/LoadedNugetPackage.cs index fe2933f7a..c96469723 100644 --- a/ILSpy/LoadedNugetPackage.cs +++ b/ILSpy/LoadedNugetPackage.cs @@ -60,7 +60,7 @@ namespace ICSharpCode.ILSpy SelectedEntries.Add(entry); else SelectedEntries.Remove(entry); - OnPropertyChanged("SelectedEntries"); + OnPropertyChanged(nameof(SelectedEntries)); } }