mirror of https://github.com/icsharpcode/ILSpy.git
Browse Source
Reopening_About_Reuses_The_Same_Tab matched any tab whose Title is "About", but two tabs can carry that title: the singleton menu-About (IsStaticContent: true, opened via OpenSingletonTab) and the transient boot welcome page (ShowWelcome, IsStaticContent: false, a non-static main-tab page shown when nothing is restored). The welcome page's presence races with boot, so when it lingered the test's .Single(IsAbout) saw two tabs and threw "Sequence contains more than one matching element" -- a ~50% order-dependent flake. The singleton is what the test means to verify, so match it precisely (IsStaticContent: true). OpenSingletonTab/CloseDockable reuse was always sound; this was purely an imprecise test predicate. Deterministic now (5/5 full-suite runs green; was ~50%).pull/3755/head
1 changed files with 4 additions and 1 deletions
Loading…
Reference in new issue