From 833bb5809c1d2482ec1a031d7d3ae2d5ffbf6887 Mon Sep 17 00:00:00 2001 From: Marcus Mikelic <29722978+samoriental@users.noreply.github.com> Date: Mon, 7 Sep 2026 20:43:44 -0400 Subject: [PATCH] [Pretty Tests] add two tests for delegate caching --- .../PrettyTestRunner.cs | 6 +++ .../TestCases/Pretty/DelegateCaching.cs | 40 +++++++++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 ICSharpCode.Decompiler.Tests/TestCases/Pretty/DelegateCaching.cs diff --git a/ICSharpCode.Decompiler.Tests/PrettyTestRunner.cs b/ICSharpCode.Decompiler.Tests/PrettyTestRunner.cs index faa5a7456..6ddbc2f5f 100644 --- a/ICSharpCode.Decompiler.Tests/PrettyTestRunner.cs +++ b/ICSharpCode.Decompiler.Tests/PrettyTestRunner.cs @@ -332,6 +332,12 @@ namespace ICSharpCode.Decompiler.Tests }); } + [Test] + public async Task DelegateCaching([ValueSource(nameof(roslyn4OrNewerOptions))] CompilerOptions cscOptions) + { + await RunForLibrary(cscOptions: cscOptions); + } + [Test] public async Task AnonymousTypes([ValueSource(nameof(defaultOptionsWithMcs))] CompilerOptions cscOptions) { diff --git a/ICSharpCode.Decompiler.Tests/TestCases/Pretty/DelegateCaching.cs b/ICSharpCode.Decompiler.Tests/TestCases/Pretty/DelegateCaching.cs new file mode 100644 index 000000000..8484a4930 --- /dev/null +++ b/ICSharpCode.Decompiler.Tests/TestCases/Pretty/DelegateCaching.cs @@ -0,0 +1,40 @@ +// Copyright (c) 2026 marcusmalloc +// +// Permission is hereby granted, free of charge, to any person obtaining a copy of this +// software and associated documentation files (the "Software"), to deal in the Software +// without restriction, including without limitation the rights to use, copy, modify, merge, +// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons +// to whom the Software is furnished to do so, subject to the following conditions: +// +// The above copyright notice and this permission notice shall be included in all copies or +// substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, +// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR +// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE +// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER +// DEALINGS IN THE SOFTWARE. + +using System; + +namespace ICSharpCode.Decompiler.Tests.TestCases.Pretty +{ + internal static class DelegateCaching + { + // Issue #3921: explicit construction must preserve a fresh delegate on each call. + public static Action FreshDelegate() + { + return new Action(M); + } + + public static Action CachedDelegate() + { + return M; + } + + private static void M() + { + } + } +}