mirror of https://github.com/icsharpcode/ILSpy.git
Browse Source
Adds MetadataTokenReference(MetadataFile, Handle). DockWorkspace subscribes to a metadata page's NavigateToCellRequested when its Content is attached; the click handler reads the row's MetadataFile and the column's int token via reflection, walks to the matching MetadataTableTreeNode under the assembly's Tables container (mapping HandleKind → TableIndex by value), selects it, and seeds ScrollToRow on the freshly-bound MetadataTablePageModel. The view's ApplyScrollTarget already honours ScrollToRow by scrolling + selecting the row. Assisted-by: Claude:claude-opus-4-7:Claude Codepull/3755/head
3 changed files with 219 additions and 1 deletions
@ -0,0 +1,101 @@ |
|||||||
|
// Copyright (c) 2026 AlphaSierraPapa for the SharpDevelop Team
|
||||||
|
//
|
||||||
|
// Permission is hereby granted, free of charge, to any person obtaining a copy of this
|
||||||
|
// software and associated documentation files (the "Software"), to deal in the Software
|
||||||
|
// without restriction, including without limitation the rights to use, copy, modify, merge,
|
||||||
|
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons
|
||||||
|
// to whom the Software is furnished to do so, subject to the following conditions:
|
||||||
|
//
|
||||||
|
// The above copyright notice and this permission notice shall be included in all copies or
|
||||||
|
// substantial portions of the Software.
|
||||||
|
//
|
||||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
|
||||||
|
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
|
||||||
|
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE
|
||||||
|
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
||||||
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
||||||
|
// DEALINGS IN THE SOFTWARE.
|
||||||
|
|
||||||
|
using System.Linq; |
||||||
|
using System.Reflection.Metadata.Ecma335; |
||||||
|
using System.Threading.Tasks; |
||||||
|
|
||||||
|
using Avalonia.Headless.NUnit; |
||||||
|
|
||||||
|
using AwesomeAssertions; |
||||||
|
|
||||||
|
using ILSpy.AppEnv; |
||||||
|
using ILSpy.Metadata; |
||||||
|
using ILSpy.Metadata.CorTables; |
||||||
|
using ILSpy.TreeNodes; |
||||||
|
using ILSpy.ViewModels; |
||||||
|
using ILSpy.Views; |
||||||
|
|
||||||
|
using NUnit.Framework; |
||||||
|
|
||||||
|
namespace ICSharpCode.ILSpy.Tests.Metadata; |
||||||
|
|
||||||
|
[TestFixture] |
||||||
|
public class MetadataTokenNavigationTests |
||||||
|
{ |
||||||
|
[AvaloniaTest] |
||||||
|
public async Task Clicking_A_Token_Cell_In_TypeDef_Navigates_To_The_Referenced_Table_Row() |
||||||
|
{ |
||||||
|
// Each TypeDef row carries a BaseType column annotated [Kind=Token]. Clicking it
|
||||||
|
// must dispatch through the docking host to the TypeRef / TypeDef / TypeSpec table
|
||||||
|
// the token belongs to and scroll the receiving grid to the referenced row.
|
||||||
|
|
||||||
|
var window = AppComposition.Current.GetExport<MainWindow>(); |
||||||
|
window.Show(); |
||||||
|
var vm = (MainWindowViewModel)window.DataContext!; |
||||||
|
await vm.AssemblyTreeModel.WaitForAssembliesAsync(minimumCount: 1); |
||||||
|
|
||||||
|
var coreLibName = typeof(object).Assembly.GetName().Name!; |
||||||
|
var assemblyNode = vm.AssemblyTreeModel.FindNode<AssemblyTreeNode>(coreLibName); |
||||||
|
assemblyNode.EnsureLazyChildren(); |
||||||
|
var metadataNode = assemblyNode.Children.OfType<MetadataTreeNode>().Single(); |
||||||
|
metadataNode.EnsureLazyChildren(); |
||||||
|
var tablesNode = metadataNode.Children.OfType<MetadataTablesTreeNode>().Single(); |
||||||
|
tablesNode.EnsureLazyChildren(); |
||||||
|
var typeDefNode = tablesNode.Children.OfType<TypeDefTableTreeNode>().Single(); |
||||||
|
|
||||||
|
vm.AssemblyTreeModel.SelectNode(typeDefNode); |
||||||
|
var tab = await vm.DockWorkspace.WaitForMetadataTabAsync(); |
||||||
|
|
||||||
|
// Pick a row whose BaseType is non-zero (skip <Module>) and resolve the expected
|
||||||
|
// target table from the handle's runtime kind.
|
||||||
|
var rowWithBase = tab.Items.Cast<TypeDefTableTreeNode.TypeDefEntry>() |
||||||
|
.First(e => e.BaseType != 0); |
||||||
|
var expectedTableIndex = (TableIndex)(int)MetadataTokens.EntityHandle(rowWithBase.BaseType).Kind; |
||||||
|
var expectedRowNumber = MetadataTokens.GetRowNumber(MetadataTokens.EntityHandle(rowWithBase.BaseType)); |
||||||
|
|
||||||
|
// Act — fire the navigate-to-cell event the way the hyperlink button does.
|
||||||
|
tab.RaiseNavigateToCell(rowWithBase, nameof(rowWithBase.BaseType)); |
||||||
|
await Waiters.WaitForAsync( |
||||||
|
() => vm.AssemblyTreeModel.SelectedItem is MetadataTableTreeNode m |
||||||
|
&& m.Kind == expectedTableIndex); |
||||||
|
|
||||||
|
// Assert — host swapped the tree selection + Content to the table matching the
|
||||||
|
// handle's kind. The actual scroll-into-view runs through MetadataTablePage's
|
||||||
|
// ApplyScrollTarget, which clears ScrollToRow synchronously after handling — so
|
||||||
|
// we don't observe the row index here, just that the selection is the right table
|
||||||
|
// and a fresh metadata page is showing.
|
||||||
|
var factory = (global::ILSpy.Docking.ILSpyDockFactory)vm.DockWorkspace.Factory; |
||||||
|
var landed = (MetadataTablePageModel)factory.MainTab!.Content!; |
||||||
|
landed.Title.Should().StartWith(expectedTableIndex.ToString()); |
||||||
|
landed.Items.Should().HaveCountGreaterThan((int)(expectedRowNumber - 1), |
||||||
|
"the target row index must be in range for the destination table"); |
||||||
|
} |
||||||
|
} |
||||||
|
|
||||||
|
internal static class MetadataTokenNavigationTestExtensions |
||||||
|
{ |
||||||
|
public static void RaiseNavigateToCell(this MetadataTablePageModel page, object row, string columnName) |
||||||
|
{ |
||||||
|
// MetadataTablePageModel.RaiseNavigateToCell is internal; tests in this assembly
|
||||||
|
// can call it because [InternalsVisibleTo] is wired in the project file.
|
||||||
|
typeof(MetadataTablePageModel) |
||||||
|
.GetMethod("RaiseNavigateToCell", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance)! |
||||||
|
.Invoke(page, [row, columnName]); |
||||||
|
} |
||||||
|
} |
||||||
@ -0,0 +1,32 @@ |
|||||||
|
// Copyright (c) 2026 AlphaSierraPapa for the SharpDevelop Team
|
||||||
|
//
|
||||||
|
// Permission is hereby granted, free of charge, to any person obtaining a copy of this
|
||||||
|
// software and associated documentation files (the "Software"), to deal in the Software
|
||||||
|
// without restriction, including without limitation the rights to use, copy, modify, merge,
|
||||||
|
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons
|
||||||
|
// to whom the Software is furnished to do so, subject to the following conditions:
|
||||||
|
//
|
||||||
|
// The above copyright notice and this permission notice shall be included in all copies or
|
||||||
|
// substantial portions of the Software.
|
||||||
|
//
|
||||||
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
|
||||||
|
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
|
||||||
|
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE
|
||||||
|
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
||||||
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
|
||||||
|
// DEALINGS IN THE SOFTWARE.
|
||||||
|
|
||||||
|
using System.Reflection.Metadata; |
||||||
|
|
||||||
|
using ICSharpCode.Decompiler.Metadata; |
||||||
|
|
||||||
|
namespace ILSpy.Metadata |
||||||
|
{ |
||||||
|
/// <summary>
|
||||||
|
/// A click target carrying a metadata token within a specific module. Emitted when the
|
||||||
|
/// user clicks a hyperlink-styled token cell in a metadata-grid view; the docking host
|
||||||
|
/// resolves it to the matching <see cref="MetadataTableTreeNode"/> and scrolls that
|
||||||
|
/// table's grid to the referenced row.
|
||||||
|
/// </summary>
|
||||||
|
public sealed record MetadataTokenReference(MetadataFile MetadataFile, Handle Handle); |
||||||
|
} |
||||||
Loading…
Reference in new issue