Merge pull request #1295 from Chicken-Bones/switchdetection

Abort SwitchAnalysis on duplicate condition (redundant code)

ICSharpCode.Decompiler.Tests/TestCases/Correctness/Loops.cs

@@ -79,6 +79,7 @@ namespace ICSharpCode.Decompiler.Tests.TestCases.Correctness
 			Console.WriteLine(NoForeachDueToMultipleCurrentAccess(new List<int> { 1, 2, 3, 4, 5 }));
 			Console.WriteLine(NoForeachCallWithSideEffect(new CustomClassEnumeratorWithIDisposable<int>()));
 			LoopWithGotoRepeat();
+			Console.WriteLine("LoopFollowedByIf: {0}", LoopFollowedByIf());
 		}
 
 		public static void ForWithMultipleVariables()
@@ -246,5 +247,17 @@ namespace ICSharpCode.Decompiler.Tests.TestCases.Correctness
 			}
 			Console.WriteLine("after finally");
 		}
+		
+		private static int LoopFollowedByIf()
+		{
+			int num = 0;
+			while (num == 0) {
+				num++;
+			}
+			if (num == 0) {
+				return -1;
+			}
+			return num;
+		}
 	}
 }

ICSharpCode.Decompiler.Tests/TestCases/ILPretty/Issue959.cs

@@ -4,7 +4,7 @@
 	{
 		public void Test(bool arg)
 		{
-			switch (arg) {
+			if (!arg && arg) {
 
 			}
 		}

ICSharpCode.Decompiler/IL/ControlFlow/SwitchAnalysis.cs

@@ -116,6 +116,8 @@ namespace ICSharpCode.Decompiler.IL.ControlFlow
 				if (!(tailOnly || block.Instructions.Count == 2))
 					return false;
 				trueValues = trueValues.IntersectWith(inputValues);
+				if (trueValues.SetEquals(inputValues) || trueValues.IsEmpty)
+					return false;
 				Block trueBlock;
 				if (trueInst.MatchBranch(out trueBlock) && AnalyzeBlock(trueBlock, trueValues)) {
 					// OK, true block was further analyzed.