Do not use ObservableObject when ObservableObjectBase is sufficient. (#3644)

* Do not use ObservableObject when ObservableObjectBase is sufficient.

ILSpy.ReadyToRun/ReadyToRunOptionPage.xaml.cs

@@ -38,7 +38,7 @@ namespace ICSharpCode.ILSpy.ReadyToRun
 
 	[ExportOptionPage(Order = 40)]
 	[NonShared]
-	class ReadyToRunOptionsViewModel : ObservableObject, IOptionPage
+	class ReadyToRunOptionsViewModel : ObservableObjectBase, IOptionPage
 	{
 		private ReadyToRunOptions options;
 

ILSpy.ReadyToRun/ReadyToRunOptions.cs

@@ -24,7 +24,7 @@ using TomsToolbox.Wpf;
 
 namespace ICSharpCode.ILSpy.ReadyToRun
 {
-	internal partial class ReadyToRunOptions : ObservableObject, ISettingsSection
+	internal partial class ReadyToRunOptions : ObservableObjectBase, ISettingsSection
 	{
 		private static readonly XNamespace ns = "http://www.ilspy.net/ready-to-run";
 

ILSpy/AssemblyTree/AssemblyTreeModel.cs

@@ -72,6 +72,8 @@ namespace ICSharpCode.ILSpy.AssemblyTree
 		private readonly LanguageService languageService;
 		private readonly IExportProvider exportProvider;
 
+		private static Dispatcher UIThreadDispatcher => Application.Current.Dispatcher;
+
 		public AssemblyTreeModel(SettingsService settingsService, LanguageService languageService, IExportProvider exportProvider)
 		{
 			this.settingsService = settingsService;
@@ -198,7 +200,7 @@ namespace ICSharpCode.ILSpy.AssemblyTree
 		{
 			var cmdArgs = CommandLineArguments.Create(args);
 
-			await Dispatcher.InvokeAsync(async () => {
+			await UIThreadDispatcher.InvokeAsync(async () => {
 
 				if (!HandleCommandLineArguments(cmdArgs))
 					return;
@@ -256,7 +258,7 @@ namespace ICSharpCode.ILSpy.AssemblyTree
 
 					// Make sure we wait for assemblies being loaded...
 					// BeginInvoke in LoadedAssembly.LookupReferencedAssemblyInternal
-					await Dispatcher.InvokeAsync(delegate { }, DispatcherPriority.Normal);
+					await UIThreadDispatcher.InvokeAsync(delegate { }, DispatcherPriority.Normal);
 
 					if (mr is { ParentModule.MetadataFile: not null })
 					{
@@ -401,7 +403,7 @@ namespace ICSharpCode.ILSpy.AssemblyTree
 				AssemblyList.Open(sessionSettings.ActiveAutoLoadedAssembly, true);
 			}
 
-			Dispatcher.BeginInvoke(DispatcherPriority.Loaded, OpenAssemblies);
+			UIThreadDispatcher.BeginInvoke(DispatcherPriority.Loaded, OpenAssemblies);
 		}
 
 		private async Task OpenAssemblies()
@@ -536,14 +538,14 @@ namespace ICSharpCode.ILSpy.AssemblyTree
 
 			if (SelectedItem == node)
 			{
-				Dispatcher.BeginInvoke(RefreshDecompiledView);
+				UIThreadDispatcher.BeginInvoke(RefreshDecompiledView);
 			}
 			else
 			{
 				activeView?.ScrollIntoView(node);
 				SelectedItem = node;
 
-				Dispatcher.BeginInvoke(DispatcherPriority.Background, () => {
+				UIThreadDispatcher.BeginInvoke(DispatcherPriority.Background, () => {
 					activeView?.ScrollIntoView(node);
 				});
 			}
@@ -795,7 +797,7 @@ namespace ICSharpCode.ILSpy.AssemblyTree
 			{
 				ContextMenuProvider.ContextMenuClosed -= ContextMenuClosed;
 
-				Dispatcher.BeginInvoke(DispatcherPriority.Background, () => {
+				UIThreadDispatcher.BeginInvoke(DispatcherPriority.Background, () => {
 					if (Mouse.RightButton != MouseButtonState.Pressed)
 					{
 						RefreshDecompiledView();

ILSpy/Docking/DockWorkspace.cs

@@ -46,7 +46,7 @@ namespace ICSharpCode.ILSpy.Docking
 {
 	[Export]
 	[Shared]
-	public class DockWorkspace : ObservableObject, ILayoutUpdateStrategy
+	public class DockWorkspace : ObservableObjectBase, ILayoutUpdateStrategy
 	{
 		private readonly IExportProvider exportProvider;
 

ILSpy/LanguageSettings.cs

@@ -31,7 +31,7 @@ namespace ICSharpCode.ILSpy
 	/// <summary>
 	/// Represents the filters applied to the tree view.
 	/// </summary>
-	public class LanguageSettings : ObservableObject, IChildSettings
+	public class LanguageSettings : ObservableObjectBase, IChildSettings
 	{
 		/// <summary>
 		/// This dictionary is necessary to remember language versions across language changes. For example, 

ILSpy/MainWindowViewModel.cs

@@ -27,7 +27,7 @@ namespace ICSharpCode.ILSpy
 {
 	[Export]
 	[Shared]
-	public class MainWindowViewModel(SettingsService settingsService, LanguageService languageService, DockWorkspace dockWorkspace) : ObservableObject
+	public class MainWindowViewModel(SettingsService settingsService, LanguageService languageService, DockWorkspace dockWorkspace) : ObservableObjectBase
 	{
 		public DockWorkspace Workspace { get; } = dockWorkspace;
 

ILSpy/Options/DisplaySettings.cs

@@ -28,7 +28,7 @@ namespace ICSharpCode.ILSpy.Options
 	/// <summary>
 	/// Description of DisplaySettings.
 	/// </summary>
-	public class DisplaySettings : ObservableObject, ISettingsSection
+	public class DisplaySettings : ObservableObjectBase, ISettingsSection
 	{
 		FontFamily selectedFont;
 		public FontFamily SelectedFont {

ILSpy/Options/DisplaySettingsViewModel.cs

@@ -14,7 +14,7 @@ namespace ICSharpCode.ILSpy.Options
 {
 	[ExportOptionPage(Order = 20)]
 	[NonShared]
-	public class DisplaySettingsViewModel : ObservableObject, IOptionPage
+	public class DisplaySettingsViewModel : ObservableObjectBase, IOptionPage
 	{
 		private DisplaySettings settings = new();
 		private FontFamily[] fontFamilies;

ILSpy/Options/MiscSettings.cs

@@ -23,7 +23,7 @@ using TomsToolbox.Wpf;
 
 namespace ICSharpCode.ILSpyX.Settings
 {
-	public class MiscSettings : ObservableObject, ISettingsSection
+	public class MiscSettings : ObservableObjectBase, ISettingsSection
 	{
 		private bool allowMultipleInstances;
 		private bool loadPreviousAssemblies = true;

ILSpy/Options/MiscSettingsViewModel.cs

@@ -34,7 +34,7 @@ namespace ICSharpCode.ILSpy.Options
 {
 	[ExportOptionPage(Order = 30)]
 	[NonShared]
-	public class MiscSettingsViewModel : ObservableObject, IOptionPage
+	public class MiscSettingsViewModel : ObservableObjectBase, IOptionPage
 	{
 		private MiscSettings settings;
 		public MiscSettings Settings {

ILSpy/Options/OptionsDialogViewModel.cs

@@ -27,14 +27,14 @@ using TomsToolbox.Wpf;
 
 namespace ICSharpCode.ILSpy.Options
 {
-	public class OptionsItemViewModel(IOptionPage content) : ObservableObject
+	public class OptionsItemViewModel(IOptionPage content) : ObservableObjectBase
 	{
 		public string Title { get; } = content.Title;
 
 		public IOptionPage Content { get; } = content;
 	}
 
-	public class OptionsDialogViewModel : ObservableObject
+	public class OptionsDialogViewModel : ObservableObjectBase
 	{
 		private IOptionPage? selectedPage;
 

ILSpy/ViewModels/CompareViewModel.cs

@@ -46,7 +46,7 @@ namespace ICSharpCode.ILSpy.ViewModels
 
 	using TomsToolbox.Wpf;
 
-	class CompareViewModel : ObservableObject
+	class CompareViewModel : ObservableObjectBase
 	{
 		private readonly TabPageModel tabPage;
 		private readonly AssemblyTreeModel assemblyTreeModel;

ILSpy/ViewModels/ManageAssemblyListsViewModel.cs

@@ -34,7 +34,7 @@ using DelegateCommand = ICSharpCode.ILSpy.Commands.DelegateCommand;
 
 namespace ICSharpCode.ILSpy.ViewModels
 {
-	public class ManageAssemblyListsViewModel : ObservableObject
+	public class ManageAssemblyListsViewModel : ObservableObjectBase
 	{
 		private readonly AssemblyListManager manager;
 		private readonly Window parent;

ILSpy/ViewModels/PaneModel.cs

@@ -27,7 +27,7 @@ using TomsToolbox.Wpf;
 
 namespace ICSharpCode.ILSpy.ViewModels
 {
-	public abstract class PaneModel : ObservableObject
+	public abstract class PaneModel : ObservableObjectBase
 	{
 		private readonly Throttle titleChangeThrottle;
 

ILSpy/ViewModels/UpdatePanelViewModel.cs

@@ -28,7 +28,7 @@ namespace ICSharpCode.ILSpy.ViewModels;
 
 [Export]
 [NonShared]
-public class UpdatePanelViewModel : ObservableObject
+public class UpdatePanelViewModel : ObservableObjectBase
 {
 	bool isPanelVisible;
 	string updateAvailableDownloadUrl;

TestPlugin/CustomOptionPage.xaml.cs

@@ -25,7 +25,7 @@ namespace TestPlugin
 
 	[ExportOptionPage(Order = 0)]
 	[NonShared]
-	class CustomOptionsViewModel : ObservableObject, IOptionPage
+	class CustomOptionsViewModel : ObservableObjectBase, IOptionPage
 	{
 		private Options options;
 
@@ -47,7 +47,7 @@ namespace TestPlugin
 		}
 	}
 
-	class Options : ObservableObject, ISettingsSection
+	class Options : ObservableObjectBase, ISettingsSection
 	{
 		static readonly XNamespace ns = "http://www.ilspy.net/testplugin";