fix search index validation (#782)

CHANGELOG.md

@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Fix processing local movie NFO metadata without a `year` value
 - Fix processing local movie fallback metadata
 - Fix search edge case where very recently added items (hours) would not be returned by relative date queries
+- Fix search index validation on startup; improper validation was causing a rebuild with every startup
 
 ### Added
 - Add `show_genre` and `show_tag` to search index for seasons and episodes

ErsatzTV.Infrastructure/Search/SearchIndex.cs

@@ -245,13 +245,21 @@ public sealed class SearchIndex : ISearchIndex
     {
         try
         {
-            using var d = FSDirectory.Open(folder);
+            using (var d = FSDirectory.Open(folder))
-            var analyzer = new StandardAnalyzer(AppLuceneVersion);
+            {
-            var indexConfig = new IndexWriterConfig(AppLuceneVersion, analyzer)
+                using (var analyzer = new StandardAnalyzer(AppLuceneVersion))
-                { OpenMode = OpenMode.CREATE_OR_APPEND };
+                {
-            using var w = new IndexWriter(_directory, indexConfig);
+                    var indexConfig = new IndexWriterConfig(AppLuceneVersion, analyzer)
-            using DirectoryReader r = w.GetReader(true);
+                        { OpenMode = OpenMode.CREATE_OR_APPEND };
-            return true;
+                    using (var w = new IndexWriter(d, indexConfig))
+                    {
+                        using (DirectoryReader _ = w.GetReader(true))
+                        {
+                            return true;
+                        }
+                    }
+                }
+            }
         }
         catch
         {