remove legacy transcoder logic option (#717)

CHANGELOG.md

@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## [Unreleased]
+### Changed
+- Remove legacy transcoder logic option; all channels will use the new transcoder logic
 
 ## [0.4.5-alpha] - 2022-03-29
 ### Fixed

ErsatzTV.Application/FFmpegProfiles/Commands/UpdateFFmpegSettingsHandler.cs

@@ -6,7 +6,7 @@ using ErsatzTV.Core.Interfaces.Repositories;
 
 namespace ErsatzTV.Application.FFmpegProfiles;
 
-public class UpdateFFmpegSettingsHandler : MediatR.IRequestHandler<UpdateFFmpegSettings, Either<BaseError, Unit>>
+public class UpdateFFmpegSettingsHandler : IRequestHandler<UpdateFFmpegSettings, Either<BaseError, Unit>>
 {
     private readonly IConfigElementRepository _configElementRepository;
     private readonly ILocalFileSystem _localFileSystem;
@@ -81,10 +81,6 @@ public class UpdateFFmpegSettingsHandler : MediatR.IRequestHandler<UpdateFFmpegS
             Directory.CreateDirectory(FileSystemLayout.FFmpegReportsFolder);
         }
 
-        await _configElementRepository.Upsert(
-            ConfigElementKey.FFmpegUseLegacyTranscoder,
-            request.Settings.UseLegacyTranscoder.ToString());
-
         await _configElementRepository.Upsert(
             ConfigElementKey.FFmpegPreferredLanguageCode,
             request.Settings.PreferredLanguageCode);

ErsatzTV.Application/FFmpegProfiles/FFmpegSettingsViewModel.cs

@@ -12,5 +12,4 @@ public class FFmpegSettingsViewModel
     public int HlsSegmenterIdleTimeout { get; set; }
     public int WorkAheadSegmenterLimit { get; set; }
     public int InitialSegmentCount { get; set; }
-    public bool UseLegacyTranscoder { get; set; }
 }

ErsatzTV.Application/FFmpegProfiles/Queries/GetFFmpegSettingsHandler.cs

@@ -32,8 +32,6 @@ public class GetFFmpegSettingsHandler : IRequestHandler<GetFFmpegSettings, FFmpe
             await _configElementRepository.GetValue<int>(ConfigElementKey.FFmpegWorkAheadSegmenters);
         Option<int> initialSegmentCount =
             await _configElementRepository.GetValue<int>(ConfigElementKey.FFmpegInitialSegmentCount);
-        Option<bool> useLegacyTranscoder =
-            await _configElementRepository.GetValue<bool>(ConfigElementKey.FFmpegUseLegacyTranscoder);
 
         var result = new FFmpegSettingsViewModel
         {
@@ -45,7 +43,6 @@ public class GetFFmpegSettingsHandler : IRequestHandler<GetFFmpegSettings, FFmpe
             HlsSegmenterIdleTimeout = await hlsSegmenterIdleTimeout.IfNoneAsync(60),
             WorkAheadSegmenterLimit = await workAheadSegmenterLimit.IfNoneAsync(1),
             InitialSegmentCount = await initialSegmentCount.IfNoneAsync(1),
-            UseLegacyTranscoder = await useLegacyTranscoder.IfNoneAsync(false)
         };
 
         foreach (int watermarkId in watermark)

ErsatzTV.Application/Streaming/Queries/GetConcatProcessByChannelNumberHandler.cs

@@ -1,7 +1,6 @@
 using System.Diagnostics;
 using ErsatzTV.Core;
 using ErsatzTV.Core.Domain;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Infrastructure.Data;
 using ErsatzTV.Infrastructure.Extensions;
@@ -11,14 +10,14 @@ namespace ErsatzTV.Application.Streaming;
 
 public class GetConcatProcessByChannelNumberHandler : FFmpegProcessHandler<GetConcatProcessByChannelNumber>
 {
-    private readonly IFFmpegProcessServiceFactory _ffmpegProcessServiceFactory;
+    private readonly IFFmpegProcessService _ffmpegProcessService;
 
     public GetConcatProcessByChannelNumberHandler(
         IDbContextFactory<TvContext> dbContextFactory,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory)
+        IFFmpegProcessService ffmpegProcessService)
         : base(dbContextFactory)
     {
-        _ffmpegProcessServiceFactory = ffmpegProcessServiceFactory;
+        _ffmpegProcessService = ffmpegProcessService;
     }
 
     protected override async Task<Either<BaseError, PlayoutItemProcessModel>> GetProcess(
@@ -32,8 +31,7 @@ public class GetConcatProcessByChannelNumberHandler : FFmpegProcessHandler<GetCo
             .GetValue<bool>(ConfigElementKey.FFmpegSaveReports)
             .Map(result => result.IfNone(false));
 
-        IFFmpegProcessService ffmpegProcessService = await _ffmpegProcessServiceFactory.GetService();
-        Process process = ffmpegProcessService.ConcatChannel(
+        Process process = _ffmpegProcessService.ConcatChannel(
             ffmpegPath,
             saveReports,
             channel,

ErsatzTV.Application/Streaming/Queries/GetPlayoutItemProcessByChannelNumberHandler.cs

@@ -4,7 +4,6 @@ using ErsatzTV.Core.Domain;
 using ErsatzTV.Core.Domain.Filler;
 using ErsatzTV.Core.Errors;
 using ErsatzTV.Core.Extensions;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.Emby;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Core.Interfaces.Jellyfin;
@@ -25,14 +24,14 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
     private readonly ITelevisionRepository _televisionRepository;
     private readonly IArtistRepository _artistRepository;
     private readonly IJellyfinPathReplacementService _jellyfinPathReplacementService;
-    private readonly IFFmpegProcessServiceFactory _ffmpegProcessServiceFactory;
+    private readonly IFFmpegProcessService _ffmpegProcessService;
     private readonly ILocalFileSystem _localFileSystem;
     private readonly IPlexPathReplacementService _plexPathReplacementService;
     private readonly ISongVideoGenerator _songVideoGenerator;
 
     public GetPlayoutItemProcessByChannelNumberHandler(
         IDbContextFactory<TvContext> dbContextFactory,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory,
+        IFFmpegProcessService ffmpegProcessService,
         ILocalFileSystem localFileSystem,
         IPlexPathReplacementService plexPathReplacementService,
         IJellyfinPathReplacementService jellyfinPathReplacementService,
@@ -43,7 +42,7 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
         ISongVideoGenerator songVideoGenerator)
         : base(dbContextFactory)
     {
-        _ffmpegProcessServiceFactory = ffmpegProcessServiceFactory;
+        _ffmpegProcessService = ffmpegProcessService;
         _localFileSystem = localFileSystem;
         _plexPathReplacementService = plexPathReplacementService;
         _jellyfinPathReplacementService = jellyfinPathReplacementService;
@@ -106,8 +105,6 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
             maybePlayoutItem = await CheckForFallbackFiller(dbContext, channel, now);
         }
 
-        IFFmpegProcessService ffmpegProcessService = await _ffmpegProcessServiceFactory.GetService();
-
         foreach (PlayoutItemWithPath playoutItemWithPath in maybePlayoutItem.RightToSeq())
         {
             MediaVersion version = playoutItemWithPath.PlayoutItem.MediaItem.GetHeadVersion();
@@ -138,7 +135,7 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
                 .GetValue<bool>(ConfigElementKey.FFmpegSaveReports)
                 .Map(result => result.IfNone(false));
 
-            Process process = await ffmpegProcessService.ForPlayoutItem(
+            Process process = await _ffmpegProcessService.ForPlayoutItem(
                 ffmpegPath,
                 saveReports,
                 channel,
@@ -179,7 +176,7 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
             switch (error)
             {
                 case UnableToLocatePlayoutItem:
-                    Process offlineProcess = await ffmpegProcessService.ForError(
+                    Process offlineProcess = await _ffmpegProcessService.ForError(
                         ffmpegPath,
                         channel,
                         maybeDuration,
@@ -189,7 +186,7 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
 
                     return new PlayoutItemProcessModel(offlineProcess, finish);
                 case PlayoutItemDoesNotExistOnDisk:
-                    Process doesNotExistProcess = await ffmpegProcessService.ForError(
+                    Process doesNotExistProcess = await _ffmpegProcessService.ForError(
                         ffmpegPath,
                         channel,
                         maybeDuration,
@@ -199,7 +196,7 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
 
                     return new PlayoutItemProcessModel(doesNotExistProcess, finish);
                 default:
-                    Process errorProcess = await ffmpegProcessService.ForError(
+                    Process errorProcess = await _ffmpegProcessService.ForError(
                         ffmpegPath,
                         channel,
                         maybeDuration,

ErsatzTV.Application/Streaming/Queries/GetWrappedProcessByChannelNumberHandler.cs

@@ -1,7 +1,6 @@
 using System.Diagnostics;
 using ErsatzTV.Core;
 using ErsatzTV.Core.Domain;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Infrastructure.Data;
 using ErsatzTV.Infrastructure.Extensions;
@@ -11,14 +10,14 @@ namespace ErsatzTV.Application.Streaming;
 
 public class GetWrappedProcessByChannelNumberHandler : FFmpegProcessHandler<GetWrappedProcessByChannelNumber>
 {
-    private readonly IFFmpegProcessServiceFactory _ffmpegProcessServiceFactory;
+    private readonly IFFmpegProcessService _ffmpegProcessService;
 
     public GetWrappedProcessByChannelNumberHandler(
         IDbContextFactory<TvContext> dbContextFactory,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory)
+        IFFmpegProcessService ffmpegProcessService)
         : base(dbContextFactory)
     {
-        _ffmpegProcessServiceFactory = ffmpegProcessServiceFactory;
+        _ffmpegProcessService = ffmpegProcessService;
     }
 
     protected override async Task<Either<BaseError, PlayoutItemProcessModel>> GetProcess(
@@ -32,8 +31,7 @@ public class GetWrappedProcessByChannelNumberHandler : FFmpegProcessHandler<GetW
             .GetValue<bool>(ConfigElementKey.FFmpegSaveReports)
             .Map(result => result.IfNone(false));
 
-        IFFmpegProcessService ffmpegProcessService = await _ffmpegProcessServiceFactory.GetService();
-        Process process = ffmpegProcessService.WrapSegmenter(
+        Process process = _ffmpegProcessService.WrapSegmenter(
             ffmpegPath,
             saveReports,
             channel,

ErsatzTV.Core/Domain/ConfigElementKey.cs

@@ -17,7 +17,6 @@ public class ConfigElementKey
     public static ConfigElementKey FFmpegSegmenterTimeout => new("ffmpeg.segmenter.timeout_seconds");
     public static ConfigElementKey FFmpegWorkAheadSegmenters => new("ffmpeg.segmenter.work_ahead_limit");
     public static ConfigElementKey FFmpegInitialSegmentCount => new("ffmpeg.segmenter.initial_segment_count");
-    public static ConfigElementKey FFmpegUseLegacyTranscoder => new("ffmpeg.use_legacy_transcoder");
     public static ConfigElementKey SearchIndexVersion => new("search_index.version");
     public static ConfigElementKey HDHRTunerCount => new("hdhr.tuner_count");
     public static ConfigElementKey ChannelsPageSize => new("pages.channels.page_size");

ErsatzTV.Core/FFmpeg/FFmpegProcessServiceFactory.cs

@@ -1,28 +0,0 @@
-using ErsatzTV.Core.Domain;
-using ErsatzTV.Core.Interfaces.FFmpeg;
-using ErsatzTV.Core.Interfaces.Repositories;
-using Microsoft.Extensions.DependencyInjection;
-
-namespace ErsatzTV.Core.FFmpeg;
-
-public class FFmpegProcessServiceFactory : IFFmpegProcessServiceFactory
-{
-    private readonly IConfigElementRepository _configElementRepository;
-    private readonly IServiceProvider _serviceProvider;
-
-    public FFmpegProcessServiceFactory(IConfigElementRepository configElementRepository, IServiceProvider serviceProvider)
-    {
-        _configElementRepository = configElementRepository;
-        _serviceProvider = serviceProvider;
-    }
-
-    public async Task<IFFmpegProcessService> GetService()
-    {
-        Option<bool> useLegacyTranscoder =
-            await _configElementRepository.GetValue<bool>(ConfigElementKey.FFmpegUseLegacyTranscoder);
-
-        return await useLegacyTranscoder.IfNoneAsync(false)
-            ? _serviceProvider.GetRequiredService<FFmpegProcessService>()
-            : _serviceProvider.GetRequiredService<FFmpegLibraryProcessService>();
-    }
-}

ErsatzTV.Core/FFmpeg/IFFmpegProcessServiceFactory.cs

@@ -1,8 +0,0 @@
-using ErsatzTV.Core.Interfaces.FFmpeg;
-
-namespace ErsatzTV.Core.FFmpeg;
-
-public interface IFFmpegProcessServiceFactory
-{
-    Task<IFFmpegProcessService> GetService();
-}

ErsatzTV.Core/FFmpeg/SongVideoGenerator.cs

@@ -14,16 +14,16 @@ public class SongVideoGenerator : ISongVideoGenerator
         
     private readonly ITempFilePool _tempFilePool;
     private readonly IImageCache _imageCache;
-    private readonly IFFmpegProcessServiceFactory _ffmpegProcessServiceFactory;
+    private readonly IFFmpegProcessService _ffmpegProcessService;
 
     public SongVideoGenerator(
         ITempFilePool tempFilePool,
         IImageCache imageCache,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory)
+        IFFmpegProcessService ffmpegProcessService)
     {
         _tempFilePool = tempFilePool;
         _imageCache = imageCache;
-        _ffmpegProcessServiceFactory = ffmpegProcessServiceFactory;
+        _ffmpegProcessService = ffmpegProcessService;
     }
 
     public async Task<Tuple<string, MediaVersion>> GenerateSongVideo(
@@ -212,8 +212,7 @@ public class SongVideoGenerator : ISongVideoGenerator
             new() { Path = videoPath }
         };
 
-        IFFmpegProcessService ffmpegProcessService = await _ffmpegProcessServiceFactory.GetService();
-        Either<BaseError, string> maybeSongImage = await ffmpegProcessService.GenerateSongImage(
+        Either<BaseError, string> maybeSongImage = await _ffmpegProcessService.GenerateSongImage(
             ffmpegPath,
             subtitleFile,
             channel,

ErsatzTV.Core/Metadata/LocalFolderScanner.cs

@@ -46,7 +46,7 @@ public abstract class LocalFolderScanner
         .ToList();
 
     private readonly IImageCache _imageCache;
-    private readonly IFFmpegProcessServiceFactory _ffmpegProcessServiceFactory;
+    private readonly IFFmpegProcessService _ffmpegProcessService;
     private readonly ITempFilePool _tempFilePool;
     private readonly IClient _client;
 
@@ -62,7 +62,7 @@ public abstract class LocalFolderScanner
         IMetadataRepository metadataRepository,
         IMediaItemRepository mediaItemRepository,
         IImageCache imageCache,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory, 
+        IFFmpegProcessService ffmpegProcessService, 
         ITempFilePool tempFilePool,
         IClient client,
         ILogger logger)
@@ -72,7 +72,7 @@ public abstract class LocalFolderScanner
         _metadataRepository = metadataRepository;
         _mediaItemRepository = mediaItemRepository;
         _imageCache = imageCache;
-        _ffmpegProcessServiceFactory = ffmpegProcessServiceFactory;
+        _ffmpegProcessService = ffmpegProcessService;
         _tempFilePool = tempFilePool;
         _client = client;
         _logger = logger;
@@ -158,14 +158,12 @@ public abstract class LocalFolderScanner
                 // if ffmpeg path is passed, we need pre-processing
                 foreach (string path in ffmpegPath)
                 {
-                    IFFmpegProcessService ffmpegProcessService = await _ffmpegProcessServiceFactory.GetService();
-                        
                     artworkFile = await attachedPicIndex.Match(
                         async picIndex =>
                         {
                             // extract attached pic (and convert to png)
                             string tempName = _tempFilePool.GetNextTempFile(TempFileCategory.CoverArt);
-                            using Process process = ffmpegProcessService.ExtractAttachedPicAsPng(
+                            using Process process = _ffmpegProcessService.ExtractAttachedPicAsPng(
                                 path,
                                 artworkFile,
                                 picIndex,
@@ -182,7 +180,7 @@ public abstract class LocalFolderScanner
                         {
                             // no attached pic index means convert to png
                             string tempName = _tempFilePool.GetNextTempFile(TempFileCategory.CoverArt);
-                            using Process process = ffmpegProcessService.ConvertToPng(path, artworkFile, tempName);
+                            using Process process = _ffmpegProcessService.ConvertToPng(path, artworkFile, tempName);
 
                             await Cli.Wrap(process.StartInfo.FileName)
                                 .WithArguments(process.StartInfo.ArgumentList)

ErsatzTV.Core/Metadata/MovieFolderScanner.cs

@@ -1,6 +1,5 @@
 using Bugsnag;
 using ErsatzTV.Core.Domain;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Core.Interfaces.Images;
 using ErsatzTV.Core.Interfaces.Metadata;
@@ -36,7 +35,7 @@ public class MovieFolderScanner : LocalFolderScanner, IMovieFolderScanner
         ILibraryRepository libraryRepository,
         IMediaItemRepository mediaItemRepository,
         IMediator mediator,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory,
+        IFFmpegProcessService ffmpegProcessService,
         ITempFilePool tempFilePool,
         IClient client,
         ILogger<MovieFolderScanner> logger)
@@ -46,7 +45,7 @@ public class MovieFolderScanner : LocalFolderScanner, IMovieFolderScanner
             metadataRepository,
             mediaItemRepository,
             imageCache,
-            ffmpegProcessServiceFactory,
+            ffmpegProcessService,
             tempFilePool,
             client,
             logger)

ErsatzTV.Core/Metadata/MusicVideoFolderScanner.cs

@@ -1,6 +1,5 @@
 using Bugsnag;
 using ErsatzTV.Core.Domain;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Core.Interfaces.Images;
 using ErsatzTV.Core.Interfaces.Metadata;
@@ -37,7 +36,7 @@ public class MusicVideoFolderScanner : LocalFolderScanner, IMusicVideoFolderScan
         ILibraryRepository libraryRepository,
         IMediaItemRepository mediaItemRepository,
         IMediator mediator,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory,
+        IFFmpegProcessService ffmpegProcessService,
         ITempFilePool tempFilePool,
         IClient client,
         ILogger<MusicVideoFolderScanner> logger) : base(
@@ -46,7 +45,7 @@ public class MusicVideoFolderScanner : LocalFolderScanner, IMusicVideoFolderScan
         metadataRepository,
         mediaItemRepository,
         imageCache,
-        ffmpegProcessServiceFactory,
+        ffmpegProcessService,
         tempFilePool,
         client,
         logger)

ErsatzTV.Core/Metadata/OtherVideoFolderScanner.cs

@@ -1,6 +1,5 @@
 using Bugsnag;
 using ErsatzTV.Core.Domain;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Core.Interfaces.Images;
 using ErsatzTV.Core.Interfaces.Metadata;
@@ -35,7 +34,7 @@ public class OtherVideoFolderScanner : LocalFolderScanner, IOtherVideoFolderScan
         IOtherVideoRepository otherVideoRepository,
         ILibraryRepository libraryRepository,
         IMediaItemRepository mediaItemRepository,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory,
+        IFFmpegProcessService ffmpegProcessService,
         ITempFilePool tempFilePool,
         IClient client,
         ILogger<OtherVideoFolderScanner> logger) : base(
@@ -44,7 +43,7 @@ public class OtherVideoFolderScanner : LocalFolderScanner, IOtherVideoFolderScan
         metadataRepository,
         mediaItemRepository,
         imageCache,
-        ffmpegProcessServiceFactory,
+        ffmpegProcessService,
         tempFilePool,
         client,
         logger)

ErsatzTV.Core/Metadata/SongFolderScanner.cs

@@ -1,7 +1,6 @@
 using Bugsnag;
 using ErsatzTV.Core.Domain;
 using ErsatzTV.Core.Extensions;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Core.Interfaces.Images;
 using ErsatzTV.Core.Interfaces.Metadata;
@@ -36,7 +35,7 @@ public class SongFolderScanner : LocalFolderScanner, ISongFolderScanner
         ISongRepository songRepository,
         ILibraryRepository libraryRepository,
         IMediaItemRepository mediaItemRepository,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory,
+        IFFmpegProcessService ffmpegProcessService,
         ITempFilePool tempFilePool,
         IClient client,
         ILogger<SongFolderScanner> logger) : base(
@@ -45,7 +44,7 @@ public class SongFolderScanner : LocalFolderScanner, ISongFolderScanner
         metadataRepository,
         mediaItemRepository,
         imageCache,
-        ffmpegProcessServiceFactory,
+        ffmpegProcessService,
         tempFilePool,
         client,
         logger)

ErsatzTV.Core/Metadata/TelevisionFolderScanner.cs

@@ -1,6 +1,5 @@
 using Bugsnag;
 using ErsatzTV.Core.Domain;
-using ErsatzTV.Core.FFmpeg;
 using ErsatzTV.Core.Interfaces.FFmpeg;
 using ErsatzTV.Core.Interfaces.Images;
 using ErsatzTV.Core.Interfaces.Metadata;
@@ -36,7 +35,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         ILibraryRepository libraryRepository,
         IMediaItemRepository mediaItemRepository,
         IMediator mediator,
-        IFFmpegProcessServiceFactory ffmpegProcessServiceFactory,
+        IFFmpegProcessService ffmpegProcessService,
         ITempFilePool tempFilePool,
         IClient client,
         ILogger<TelevisionFolderScanner> logger) : base(
@@ -45,7 +44,7 @@ public class TelevisionFolderScanner : LocalFolderScanner, ITelevisionFolderScan
         metadataRepository,
         mediaItemRepository,
         imageCache,
-        ffmpegProcessServiceFactory,
+        ffmpegProcessService,
         tempFilePool,
         client,
         logger)

ErsatzTV/Pages/Settings.razor

@@ -94,12 +94,6 @@
                                       Required="true"
                                       RequiredError="HLS Segmenter initial segment count is required!"/>
                     </MudElement>
-                    <MudElement HtmlTag="div" Class="mt-3">
-                        <MudSwitch T="bool"
-                                   Label="Use Legacy Transcoder Logic"
-                                   Color="Color.Primary"
-                                   @bind-Checked="@_ffmpegSettings.UseLegacyTranscoder"/>
-                    </MudElement>
                 </MudForm>
             </MudCardContent>
             <MudCardActions>

ErsatzTV/Startup.cs

@@ -381,9 +381,7 @@ public class Startup
         services.AddScoped<IPlexPathReplacementService, PlexPathReplacementService>();
         services.AddScoped<IFFmpegStreamSelector, FFmpegStreamSelector>();
             
-        // services.AddScoped<IFFmpegProcessService, FFmpegProcessService>();
-        services.AddScoped<IFFmpegProcessServiceFactory, FFmpegProcessServiceFactory>();
-        services.AddScoped<FFmpegLibraryProcessService>();
+        services.AddScoped<IFFmpegProcessService, FFmpegLibraryProcessService>();
         services.AddScoped<FFmpegProcessService>();
             
         services.AddScoped<ISongVideoGenerator, SongVideoGenerator>();