From da8d52cf8f65f9cf5959429dc97fc33de0a906ac Mon Sep 17 00:00:00 2001 From: Jon Crall Date: Tue, 30 Dec 2025 16:08:32 -0500 Subject: [PATCH] Rename select-all helper and avoid shift tracking --- ErsatzTV.Core.Tests/Pages/MediaCardSelectionHelperTests.cs | 4 ++-- ErsatzTV/Pages/MultiSelectBase.cs | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/ErsatzTV.Core.Tests/Pages/MediaCardSelectionHelperTests.cs b/ErsatzTV.Core.Tests/Pages/MediaCardSelectionHelperTests.cs index e287f4ed8..9927bd350 100644 --- a/ErsatzTV.Core.Tests/Pages/MediaCardSelectionHelperTests.cs +++ b/ErsatzTV.Core.Tests/Pages/MediaCardSelectionHelperTests.cs @@ -18,7 +18,7 @@ public class MediaCardSelectionHelperTests var first = new MediaCardViewModel(2, "First", "Sub", "First", "", Core.Domain.MediaItemState.Normal, false); var second = new MediaCardViewModel(3, "Second", "Sub", "Second", "", Core.Domain.MediaItemState.Normal, false); - MediaCardViewModel last = MultiSelectBase.SelectAllPageItems(selected, new[] { first, second }); + MediaCardViewModel last = MultiSelectBase.ResetSelectionWithCards(selected, new[] { first, second }); selected.ShouldBe(new[] { first, second }, ignoreOrder: true); last.ShouldBe(second); @@ -30,7 +30,7 @@ public class MediaCardSelectionHelperTests var existingCard = new MediaCardViewModel(1, "Existing", "Sub", "Existing", "", Core.Domain.MediaItemState.Normal, false); var selected = new HashSet { existingCard }; - MediaCardViewModel last = MultiSelectBase.SelectAllPageItems(selected, []); + MediaCardViewModel last = MultiSelectBase.ResetSelectionWithCards(selected, []); selected.ShouldBeEmpty(); last.ShouldBeNull(); diff --git a/ErsatzTV/Pages/MultiSelectBase.cs b/ErsatzTV/Pages/MultiSelectBase.cs index e631f6615..89ae6fdb4 100644 --- a/ErsatzTV/Pages/MultiSelectBase.cs +++ b/ErsatzTV/Pages/MultiSelectBase.cs @@ -42,8 +42,7 @@ public class MultiSelectBase : FragmentNavigationBase protected void SelectAllPageItems(IEnumerable cards) { - MediaCardViewModel lastSelected = SelectAllPageItems(SelectedItems, cards); - _recentlySelected = Optional(lastSelected); + ResetSelectionWithCards(SelectedItems, cards); StateHasChanged(); } @@ -249,7 +248,7 @@ public class MultiSelectBase : FragmentNavigationBase } } - internal static MediaCardViewModel SelectAllPageItems( + internal static MediaCardViewModel ResetSelectionWithCards( ISet selectedItems, IEnumerable cards) {