From cc9880c2f05941009cb5ec73ea895cd940ddcfd4 Mon Sep 17 00:00:00 2001 From: Jason Dove <1695733+jasongdove@users.noreply.github.com> Date: Fri, 22 May 2026 13:39:39 -0500 Subject: [PATCH] feat: always save error reports with next engine (#2907) * update dependencies * feat: always save error reports with next engine --- .../Commands/StartFFmpegNextSessionHandler.cs | 15 +++++---------- ErsatzTV.Core/ErsatzTV.Core.csproj | 2 +- ErsatzTV.Core/Next/Config/ChannelConfig.cs | 3 --- ErsatzTV.FFmpeg/ErsatzTV.FFmpeg.csproj | 2 +- .../ErsatzTV.Infrastructure.csproj | 2 +- 5 files changed, 8 insertions(+), 16 deletions(-) diff --git a/ErsatzTV.Application/Streaming/Commands/StartFFmpegNextSessionHandler.cs b/ErsatzTV.Application/Streaming/Commands/StartFFmpegNextSessionHandler.cs index 4d4df1b0a..61264cf44 100644 --- a/ErsatzTV.Application/Streaming/Commands/StartFFmpegNextSessionHandler.cs +++ b/ErsatzTV.Application/Streaming/Commands/StartFFmpegNextSessionHandler.cs @@ -281,7 +281,11 @@ public class StartFFmpegNextSessionHandler( FFmpegProfileViewModel ffmpegProfile, CancellationToken cancellationToken) { - var ffmpeg = new Ffmpeg(); + var ffmpeg = new Ffmpeg + { + // next only keeps errors, so always pass the folder + ReportsFolder = FileSystemLayout.FFmpegReportsFolder + }; Option ffmpegPath = await configElementRepository.GetValue( ConfigElementKey.FFmpegPath, @@ -305,15 +309,6 @@ public class StartFFmpegNextSessionHandler( ConfigElementKey.FFmpegSaveReports, cancellationToken); - foreach (bool saveReports in maybeSaveReports) - { - if (saveReports) - { - ffmpeg.SaveReports = true; - ffmpeg.ReportsFolder = FileSystemLayout.FFmpegReportsFolder; - } - } - var audioNormalization = new Audio { Format = ffmpegProfile.AudioFormat switch diff --git a/ErsatzTV.Core/ErsatzTV.Core.csproj b/ErsatzTV.Core/ErsatzTV.Core.csproj index 030d71736..76dcd1443 100644 --- a/ErsatzTV.Core/ErsatzTV.Core.csproj +++ b/ErsatzTV.Core/ErsatzTV.Core.csproj @@ -30,7 +30,7 @@ - + diff --git a/ErsatzTV.Core/Next/Config/ChannelConfig.cs b/ErsatzTV.Core/Next/Config/ChannelConfig.cs index 3766b8a07..006fa1bdf 100644 --- a/ErsatzTV.Core/Next/Config/ChannelConfig.cs +++ b/ErsatzTV.Core/Next/Config/ChannelConfig.cs @@ -43,9 +43,6 @@ namespace ErsatzTV.Core.Next.Config [JsonProperty("reports_folder")] public string ReportsFolder { get; set; } - - [JsonProperty("save_reports", NullValueHandling = NullValueHandling.Ignore)] - public bool? SaveReports { get; set; } } public partial class Normalization diff --git a/ErsatzTV.FFmpeg/ErsatzTV.FFmpeg.csproj b/ErsatzTV.FFmpeg/ErsatzTV.FFmpeg.csproj index eb5ee98b0..3d3b74341 100644 --- a/ErsatzTV.FFmpeg/ErsatzTV.FFmpeg.csproj +++ b/ErsatzTV.FFmpeg/ErsatzTV.FFmpeg.csproj @@ -12,7 +12,7 @@ - + diff --git a/ErsatzTV.Infrastructure/ErsatzTV.Infrastructure.csproj b/ErsatzTV.Infrastructure/ErsatzTV.Infrastructure.csproj index b8085653d..2a020bf19 100644 --- a/ErsatzTV.Infrastructure/ErsatzTV.Infrastructure.csproj +++ b/ErsatzTV.Infrastructure/ErsatzTV.Infrastructure.csproj @@ -16,7 +16,7 @@ - +