From a99249c375feef26e13f9e9a2ee90a0fe5652c2c Mon Sep 17 00:00:00 2001 From: Jason Dove Date: Thu, 30 Sep 2021 17:35:44 -0500 Subject: [PATCH] revert nvenc changes (#389) --- CHANGELOG.md | 7 ++++++- .../FFmpeg/FFmpegComplexFilterBuilderTests.cs | 12 ++++++------ ErsatzTV.Core/FFmpeg/FFmpegComplexFilterBuilder.cs | 3 +-- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 83c8bdc18..07478c81c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] +## [0.0.61-alpha] - 2021-09-30 +### Fixed +- Revert nvenc/cuda filter change from v60 + ## [0.0.60-alpha] - 2021-09-25 ### Added - Add Trakt list support under `Lists` > `Trakt Lists` @@ -630,7 +634,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). - Initial release to facilitate testing outside of Docker. -[Unreleased]: https://github.com/jasongdove/ErsatzTV/compare/v0.0.60-alpha...HEAD +[Unreleased]: https://github.com/jasongdove/ErsatzTV/compare/v0.0.61-alpha...HEAD +[0.0.61-alpha]: https://github.com/jasongdove/ErsatzTV/compare/v0.0.60-alpha...v0.0.61-alpha [0.0.60-alpha]: https://github.com/jasongdove/ErsatzTV/compare/v0.0.59-alpha...v0.0.60-alpha [0.0.59-alpha]: https://github.com/jasongdove/ErsatzTV/compare/v0.0.58-alpha...v0.0.59-alpha [0.0.58-alpha]: https://github.com/jasongdove/ErsatzTV/compare/v0.0.57-alpha...v0.0.58-alpha diff --git a/ErsatzTV.Core.Tests/FFmpeg/FFmpegComplexFilterBuilderTests.cs b/ErsatzTV.Core.Tests/FFmpeg/FFmpegComplexFilterBuilderTests.cs index 2616b5477..7c250b6e3 100644 --- a/ErsatzTV.Core.Tests/FFmpeg/FFmpegComplexFilterBuilderTests.cs +++ b/ErsatzTV.Core.Tests/FFmpeg/FFmpegComplexFilterBuilderTests.cs @@ -365,37 +365,37 @@ namespace ErsatzTV.Core.Tests.FFmpeg true, true, false, - "[0:0]hwupload_cuda,scale_npp=1920:1000,hwdownload,format=yuv420p|nv12,setsar=1,hwupload[v]", + "[0:0]scale_npp=1920:1000,hwdownload,format=nv12,setsar=1,hwupload[v]", "[v]")] [TestCase( true, false, true, - "[0:0]hwdownload,format=yuv420p|nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", + "[0:0]hwdownload,format=nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", "[v]")] [TestCase( true, true, true, - "[0:0]hwupload_cuda,scale_npp=1920:1000,hwdownload,format=yuv420p|nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", + "[0:0]scale_npp=1920:1000,hwdownload,format=nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", "[v]")] [TestCase( false, true, false, - "[0:0]hwupload_cuda,scale_npp=1920:1000,hwdownload,format=yuv420p|nv12,setsar=1,hwupload[v]", + "[0:0]scale_npp=1920:1000,hwdownload,format=nv12,setsar=1,hwupload[v]", "[v]")] [TestCase( false, false, true, - "[0:0]hwdownload,format=yuv420p|nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", + "[0:0]hwdownload,format=nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", "[v]")] [TestCase( false, true, true, - "[0:0]hwupload_cuda,scale_npp=1920:1000,hwdownload,format=yuv420p|nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", + "[0:0]scale_npp=1920:1000,hwdownload,format=nv12,setsar=1,pad=1920:1080:(ow-iw)/2:(oh-ih)/2,hwupload[v]", "[v]")] public void Should_Return_NVENC_Video_Filter( bool deinterlace, diff --git a/ErsatzTV.Core/FFmpeg/FFmpegComplexFilterBuilder.cs b/ErsatzTV.Core/FFmpeg/FFmpegComplexFilterBuilder.cs index 7a70f22fe..68dd0665f 100644 --- a/ErsatzTV.Core/FFmpeg/FFmpegComplexFilterBuilder.cs +++ b/ErsatzTV.Core/FFmpeg/FFmpegComplexFilterBuilder.cs @@ -137,7 +137,7 @@ namespace ErsatzTV.Core.FFmpeg HardwareAccelerationKind.Qsv => $"scale_qsv=w={size.Width}:h={size.Height}", HardwareAccelerationKind.Nvenc when _pixelFormat == "yuv420p10le" => $"hwdownload,format=p010le,format=nv12,hwupload,scale_npp={size.Width}:{size.Height}", - HardwareAccelerationKind.Nvenc => $"hwupload_cuda,scale_npp={size.Width}:{size.Height}", + HardwareAccelerationKind.Nvenc => $"scale_npp={size.Width}:{size.Height}", HardwareAccelerationKind.Vaapi => $"scale_vaapi=w={size.Width}:h={size.Height}", _ => $"scale={size.Width}:{size.Height}:flags=fast_bilinear" }; @@ -161,7 +161,6 @@ namespace ErsatzTV.Core.FFmpeg HardwareAccelerationKind.Vaapi => "format=nv12|vaapi", HardwareAccelerationKind.Nvenc when _scaleToSize.IsNone && _pixelFormat == "yuv420p10le" => "format=p010le,format=nv12", - HardwareAccelerationKind.Nvenc => "format=yuv420p|nv12", _ => "format=nv12" }; videoFilterQueue.Add(format);