fix default song background for 4:3 resolutions (#1951)

* fix default song background for 4:3 resolutions

* use 16:9 progress overlay for now

CHANGELOG.md

@@ -39,6 +39,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Fix synchronizing Plex collections
   - If this breaks collection sync for you, you will need to update your Plex server
 - Fix guide group generation for `duration` YAML instructions
+- Fix default song background when targeting 4:3 resolutions
+  - Previously the background was always 16:9 and was padded, now it will fill 4:3
 
 ## [0.8.8-beta] - 2024-09-19
 ### Added

ErsatzTV.Application/Streaming/Queries/GetPlayoutItemProcessByChannelNumberHandler.cs

@@ -261,6 +261,8 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
                 // override watermark as song_progress_overlay.png
                 if (videoVersion is BackgroundImageMediaVersion { IsSongWithProgress: true })
                 {
+                    string image = "song_progress_overlay.png";
+
                     disableWatermarks = false;
                     playoutItemWatermark = new ChannelWatermark
                     {
@@ -272,7 +274,7 @@ public class GetPlayoutItemProcessByChannelNumberHandler : FFmpegProcessHandler<
                         Opacity = 100,
                         Location = WatermarkLocation.TopLeft,
                         ImageSource = ChannelWatermarkImageSource.Resource,
-                        Image = "song_progress_overlay.png"
+                        Image = image
                     };
                 }
             }

ErsatzTV.Core/FFmpeg/SongVideoGenerator.cs

@@ -41,8 +41,8 @@ public class SongVideoGenerator : ISongVideoGenerator
         {
             Id = -1,
             Chapters = [],
-            Width = 192,
-            Height = 108,
+            Width = channel.FFmpegProfile.Resolution.Width / 10,
+            Height = channel.FFmpegProfile.Resolution.Height / 10,
             SampleAspectRatio = "1:1",
             Streams = [new MediaStream { MediaStreamKind = MediaStreamKind.Video, Index = 0, PixelFormat = "yuv420p" }]
         };
@@ -173,8 +173,8 @@ public class SongVideoGenerator : ISongVideoGenerator
             {
                 Chapters = [],
                 // always stretch cover art
-                Width = 192,
-                Height = 108,
+                Width = channel.FFmpegProfile.Resolution.Width / 10,
+                Height = channel.FFmpegProfile.Resolution.Height / 10,
                 SampleAspectRatio = "1:1",
                 Streams = new List<MediaStream>
                 {

ErsatzTV/ErsatzTV.csproj

@@ -87,6 +87,7 @@
       <EmbeddedResource Include="Resources\Templates\_musicVideo.sbntxt" />
       <EmbeddedResource Include="Resources\Templates\_otherVideo.sbntxt" />
       <EmbeddedResource Include="Resources\Templates\_song.sbntxt" />
+      <EmbeddedResource Include="Resources\song_progress_overlay_43.png" />
     </ItemGroup>
 
     <ItemGroup>

ErsatzTV/Services/RunOnce/ResourceExtractorService.cs

@@ -22,6 +22,7 @@ public class ResourceExtractorService : BackgroundService
         await ExtractResource(assembly, "song_background_2.png", stoppingToken);
         await ExtractResource(assembly, "song_background_3.png", stoppingToken);
         await ExtractResource(assembly, "song_progress_overlay.png", stoppingToken);
+        await ExtractResource(assembly, "song_progress_overlay_43.png", stoppingToken);
         await ExtractResource(assembly, "ErsatzTV.png", stoppingToken);
 
         await ExtractFontResource(assembly, "Sen.ttf", stoppingToken);