fix duration playout loop (#1796)

CHANGELOG.md

@@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Fix artwork in other video libraries by @raknam
 - Fix adding items to empty playlists
 - Fix filler preset editor and deco dead air fallback editor to only show supported collection types
+- Fix infinite loop caused by impossible schedule (all collection items longer than schedule item duration)
 
 ### Changed
 - Remove some unnecessary API calls related to media server scanning and paging

ErsatzTV.Core/Scheduling/PlayoutBuilder.cs

@@ -666,7 +666,7 @@ public class PlayoutBuilder : IPlayoutBuilder
             if (timeCount[playoutBuilderState.CurrentTime] == 6)
             {
                 _logger.LogWarning(
-                    "Failed to schedule beyond {Time}; aborting playout build - this is a bug",
+                    "Failed to schedule beyond {Time}; aborting playout build - this can be caused by an impossible schedule, or by a bug",
                     playoutBuilderState.CurrentTime);
 
                 throw new InvalidOperationException("Scheduling loop encountered");

ErsatzTV.Core/Scheduling/PlayoutModeSchedulerDuration.cs

@@ -77,6 +77,31 @@ public class PlayoutModeSchedulerDuration : PlayoutModeSchedulerBase<ProgramSche
 
             if (itemDuration > scheduleItem.PlayoutDuration)
             {
+                var fail = false;
+                foreach (TimeSpan minimumDuration in contentEnumerator.MinimumDuration)
+                {
+                    if (minimumDuration > scheduleItem.PlayoutDuration)
+                    {
+                        Logger.LogError(
+                            "Collection with minimum duration {Duration:hh\\:mm\\:ss} will never fit in schedule item with duration {PlayoutDuration:hh\\:mm\\:ss}; skipping this schedule item!",
+                            minimumDuration,
+                            scheduleItem.PlayoutDuration);
+
+                        nextState = nextState with
+                        {
+                            DurationFinish = None
+                        };
+
+                        nextState.ScheduleItemsEnumerator.MoveNext();
+                        fail = true;
+                    }
+                }
+
+                if (fail)
+                {
+                    break;
+                }
+
                 Logger.LogWarning(
                     "Skipping playout item {Title} with duration {Duration:hh\\:mm\\:ss} that will never fit in schedule item duration {PlayoutDuration:hh\\:mm\\:ss}",
                     PlayoutBuilder.DisplayTitle(mediaItem),