fix other video artwork in xmltv (#2777)

CHANGELOG.md

@@ -24,6 +24,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - MySql: fix searching for shows and seasons in schedule items editor
 - Fix 500 errors when serving XMLTV due to concurrent file reads and writes
 - Fix playback of AC3 audio when targeting stereo output and input layout changes mid-stream
+- Use other video artwork in XMLTV template
+- Remove artwork from other videos when artwork has been removed from disk
 
 ## [26.1.1] - 2026-01-08
 ### Fixed

ErsatzTV.Application/Channels/Commands/RefreshChannelDataHandler.cs

@@ -883,6 +883,8 @@ public class RefreshChannelDataHandler : IRequestHandler<RefreshChannelData>
             metadata.Genres ??= [];
             metadata.Guids ??= [];
 
+            string artworkPath = GetPrioritizedArtworkPath(metadata);
+
             var data = new
             {
                 ProgrammeStart = start,
@@ -897,6 +899,8 @@ public class RefreshChannelDataHandler : IRequestHandler<RefreshChannelData>
                 OtherVideoPlot = metadata.Plot,
                 OtherVideoHasYear = metadata.Year.HasValue,
                 OtherVideoYear = metadata.Year,
+                OtherVideoHasArtwork = !string.IsNullOrWhiteSpace(artworkPath),
+                OtherVideoArtworkUrl = artworkPath,
                 OtherVideoGenres = metadata.Genres.Map(g => g.Name).OrderBy(n => n),
                 OtherVideoHasContentRating = !string.IsNullOrWhiteSpace(metadata.ContentRating),
                 OtherVideoContentRating = metadata.ContentRating

ErsatzTV.Core/Interfaces/Repositories/IOtherVideoRepository.cs

@@ -19,4 +19,5 @@ public interface IOtherVideoRepository
     Task<bool> AddActor(OtherVideoMetadata metadata, Actor actor);
     Task<bool> AddDirector(OtherVideoMetadata metadata, Director director);
     Task<bool> AddWriter(OtherVideoMetadata metadata, Writer writer);
+    Task<bool> RemoveArtwork(OtherVideoMetadata metadata, ArtworkKind artworkKind);
 }

ErsatzTV.Infrastructure/Data/Repositories/OtherVideoRepository.cs

@@ -46,6 +46,8 @@ public class OtherVideoRepository : IOtherVideoRepository
             .ThenInclude(ovm => ovm.Directors)
             .Include(i => i.OtherVideoMetadata)
             .ThenInclude(ovm => ovm.Writers)
+            .Include(i => i.OtherVideoMetadata)
+            .ThenInclude(ovm => ovm.Artwork)
             .Include(ov => ov.LibraryPath)
             .ThenInclude(lp => lp.Library)
             .Include(ov => ov.MediaVersions)
@@ -173,6 +175,15 @@ public class OtherVideoRepository : IOtherVideoRepository
             new { writer.Name, MetadataId = metadata.Id }).Map(result => result > 0);
     }
 
+    public async Task<bool> RemoveArtwork(OtherVideoMetadata metadata, ArtworkKind artworkKind)
+    {
+        await using TvContext dbContext = await _dbContextFactory.CreateDbContextAsync();
+        var ids = metadata.Artwork.Where(a => a.ArtworkKind == artworkKind).Select(a => a.Id).ToHashSet();
+        return await dbContext.Artwork
+            .Where(a => ids.Contains(a.Id))
+            .ExecuteDeleteAsync() > 0;
+    }
+
     private async Task<Either<BaseError, MediaItemScanResult<OtherVideo>>> AddOtherVideo(
         TvContext dbContext,
         int libraryPathId,

ErsatzTV.Scanner/Core/Metadata/OtherVideoFolderScanner.cs

@@ -359,11 +359,18 @@ public class OtherVideoFolderScanner : LocalFolderScanner, IOtherVideoFolderScan
         {
             OtherVideo otherVideo = result.Item;
 
-            Option<string> maybeThumbnail = LocateThumbnail(otherVideo);
+            foreach (var metadata in otherVideo.OtherVideoMetadata.HeadOrNone())
-            foreach (string thumbnailFile in maybeThumbnail)
             {
-                OtherVideoMetadata metadata = otherVideo.OtherVideoMetadata.Head();
+                Option<string> maybeThumbnail = LocateThumbnail(otherVideo);
-                await RefreshArtwork(thumbnailFile, metadata, ArtworkKind.Thumbnail, None, None, cancellationToken);
+                foreach (string thumbnailFile in maybeThumbnail)
+                {
+                    await RefreshArtwork(thumbnailFile, metadata, ArtworkKind.Thumbnail, None, None, cancellationToken);
+                }
+
+                if (maybeThumbnail.IsNone && metadata.Artwork.Any(a => a.ArtworkKind is ArtworkKind.Thumbnail))
+                {
+                    await _otherVideoRepository.RemoveArtwork(metadata, ArtworkKind.Thumbnail);
+                }
             }
 
             return result;

ErsatzTV/Resources/Templates/_otherVideo.sbntxt

@@ -13,6 +13,8 @@ Available values:
   - other_video_plot
   - other_video_has_year
   - other_video_year
+  - other_video_has_artwork
+  - other_video_artwork_url
   - other_video_genres
   - other_video_has_content_rating
   - other_video_content_rating
@@ -35,8 +37,8 @@ The resulting XML will be minified by ErsatzTV - so feel free to keep things nic
       {{ for genre in other_video_genres }}
         <category lang="en">{{ genre }}</category>
       {{ end }}
-      {{ if movie_has_artwork }}
+      {{ if other_video_has_artwork }}
-        <icon src="{{ movie_artwork_url }}" />
+        <icon src="{{ other_video_artwork_url }}" />
       {{ end }}
   {{ end }}
   {{ if other_video_has_content_rating }}