From 36d3d385309f9b35186e8d53ad982f663da80c58 Mon Sep 17 00:00:00 2001 From: Jason Dove Date: Tue, 16 Aug 2022 12:25:59 -0500 Subject: [PATCH] remove all use of setsar filter (#928) --- CHANGELOG.md | 2 ++ ErsatzTV.FFmpeg/PipelineBuilder.cs | 12 ------------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c1977cf0e..4c6071880 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ## [Unreleased] ### Fixed - Use MIME Type `application/x-mpegurl` for all playlists instead of `application/vnd.apple.mpegurl` +- Remove `setsar` filter which caused issues scaling between two different aspect ratios + - For example, some 4:3 content would appear stretched when scaled to a 16:9 resolution ### Added - Support DSD audio file formats (DFF and DSF) in local song libraries diff --git a/ErsatzTV.FFmpeg/PipelineBuilder.cs b/ErsatzTV.FFmpeg/PipelineBuilder.cs index d2f606f51..771f0b0b9 100644 --- a/ErsatzTV.FFmpeg/PipelineBuilder.cs +++ b/ErsatzTV.FFmpeg/PipelineBuilder.cs @@ -379,10 +379,6 @@ public class PipelineBuilder IPipelineFilterStep padStep = new PadFilter(currentState, desiredState.PaddedSize); currentState = padStep.NextState(currentState); _videoInputFile.Iter(f => f.FilterSteps.Add(padStep)); - - IPipelineFilterStep sarStep = new SetSarFilter(); - currentState = sarStep.NextState(currentState); - _videoInputFile.Iter(f => f.FilterSteps.Add(sarStep)); } } else if (currentState.ScaledSize != desiredState.ScaledSize) @@ -402,10 +398,6 @@ public class PipelineBuilder currentState = padStep.NextState(currentState); _videoInputFile.Iter(f => f.FilterSteps.Add(padStep)); } - - IPipelineFilterStep sarStep = new SetSarFilter(); - currentState = sarStep.NextState(currentState); - _videoInputFile.Iter(f => f.FilterSteps.Add(sarStep)); } else if (currentState.PaddedSize != desiredState.PaddedSize) { @@ -423,10 +415,6 @@ public class PipelineBuilder currentState = padStep.NextState(currentState); _videoInputFile.Iter(f => f.FilterSteps.Add(padStep)); } - - IPipelineFilterStep sarStep = new SetSarFilter(); - currentState = sarStep.NextState(currentState); - _videoInputFile.Iter(f => f.FilterSteps.Add(sarStep)); } if (hasOverlay && currentState.PixelFormat.Map(pf => pf.FFmpegName) !=