Ensure enumerations lack conflicts when renamed

Fixes https://github.com/mono/CppSharp/issues/965.

Signed-off-by: Dimitar Dobrev <dpldobrev@protonmail.com>

src/Generator/Passes/RenamePass.cs

@@ -215,9 +215,14 @@ namespace CppSharp.Passes
 
             var property = decl as Property;
             if (property != null && property.Field != null)
-                return ((Class) decl.Namespace).Properties.FirstOrDefault(
+                return ((Class) decl.Namespace).Properties.Find(
                     p => p != decl && p.Name == newName) != null;
 
+            var enumItem = decl as Enumeration.Item;
+            if (enumItem != null)
+                return ((Enumeration) enumItem.Namespace).Items.Any(
+                    i => i != decl && i.Name == newName);
+
             return false;
         }
 

tests/Common/Common.Tests.cs

@@ -51,14 +51,14 @@ public class CommonTests : GeneratorTestFixture
         {
             hasPropertyNamedAsParent.hasPropertyNamedAsParent.GetHashCode();
         }
-        EnumWithUnderscores e = EnumWithUnderscores.lOWER_BEFORE_CAPITAL;
+        EnumWithUnderscores.lOWER_BEFORE_CAPITAL.GetHashCode();
-        e = EnumWithUnderscores.UnderscoreAtEnd;
+        EnumWithUnderscores.UnderscoreAtEnd.GetHashCode();
-        e = EnumWithUnderscores.CAPITALS_More;
+        EnumWithUnderscores.CAPITALS_More.GetHashCode();
-        e = EnumWithUnderscores.UsesDigits1_0;
+        EnumWithUnderscores.UsesDigits1_0.GetHashCode();
-        e.GetHashCode();
+        ItemsDifferByCase.Case_a.GetHashCode();
-        ItemsDifferByCase itemsDifferByCase = ItemsDifferByCase.Case_a;
+        ItemsDifferByCase.CaseA.GetHashCode();
-        itemsDifferByCase = ItemsDifferByCase.CaseA;
+        Enum.NAME_A.GetHashCode();
-        itemsDifferByCase.GetHashCode();
+        Enum.NAME__A.GetHashCode();
         new AmbiguousParamNames(0, 0).Dispose();
         Common.SMallFollowedByCapital();
         Common.IntegerOverload(0);

tests/Common/Common.h

@@ -191,7 +191,9 @@ enum Enum
     A = 0, B = 2, C = 5,
     //D = 0x80000000,
     E = 0x1,
-    F = -9
+    F = -9,
+    NAME_A = 10,
+    NAME__A = 20
 };
 
 typedef char TypedefChar;