Improved the generation of indexers by removing const overloads of []. NOTE: did that by removing the method type check in the pass for ambiguous overloads.

Signed-off-by: Dimitar Dobrev <dpldobrev@yahoo.com>

src/Generator/Driver.cs

@@ -140,9 +140,9 @@ namespace CppSharp
 
             TranslationUnitPasses.AddPass(new FindSymbolsPass());
             TranslationUnitPasses.AddPass(new MoveOperatorToClassPass());
+            TranslationUnitPasses.AddPass(new CheckAmbiguousFunctions());
             TranslationUnitPasses.AddPass(new CheckOperatorsOverloadsPass());
             TranslationUnitPasses.AddPass(new CheckVirtualOverrideReturnCovariance());
-            TranslationUnitPasses.AddPass(new CheckAmbiguousFunctions());
 
             Generator.SetupPasses();
             TranslationUnitPasses.AddPass(new FieldToPropertyPass());

src/Generator/Passes/CheckAmbiguousFunctions.cs

@@ -23,14 +23,6 @@ namespace CppSharp.Passes
     /// </summary>
     public class CheckAmbiguousFunctions : TranslationUnitPass
     {
-        public override bool VisitMethodDecl(Method method)
-        {
-            if (method.Kind != CXXMethodKind.Normal)
-                return false;
-
-            return base.VisitMethodDecl(method);
-        }
-
         public override bool VisitFunctionDecl(AST.Function function)
         {
             if (AlreadyVisited(function))

src/Generator/Passes/CheckOperatorsOverloads.cs

@@ -44,7 +44,7 @@ namespace CppSharp.Passes
 
         private void CheckInvalidOperators(Class @class)
         {
-            foreach (var @operator in @class.Operators)
+            foreach (var @operator in @class.Operators.Where(o => !o.Ignore))
             {
                 if (!IsValidOperatorOverload(@operator))
                 {
@@ -85,21 +85,17 @@ namespace CppSharp.Passes
 
         private static void CreateIndexer(Class @class, Method @operator)
         {
-            if (@class.Properties.All(p => p.Parameters.Count == 0 || 
+            Property property = new Property
-                p.Parameters[0].QualifiedType != @operator.Parameters[0].QualifiedType))
             {
-                Property property = new Property
+                Name = "Item",
-                    {
+                QualifiedType = @operator.ReturnType,
-                        Name = "Item",
+                Access = @operator.Access,
-                        QualifiedType = @operator.ReturnType,
+                Namespace = @class,
-                        Access = @operator.Access,
+                GetMethod = @operator
-                        Namespace = @class
+            };
-                    };
+            property.Parameters.AddRange(@operator.Parameters);
-                property.GetMethod = @operator;
+            @class.Properties.Add(property);
-                property.Parameters.AddRange(@operator.Parameters);
+            @operator.IsGenerated = false;
-                @class.Properties.Add(property);
-                @operator.IsGenerated = false;
-            }
         }
 
         static void HandleMissingOperatorOverloadPair(Class @class, CXXOperatorKind op1,